Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/revs3 #502

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Gb/revs3 #502

merged 5 commits into from
Jan 10, 2025

Conversation

grantbuster
Copy link
Member

@grantbuster grantbuster commented Jan 10, 2025

Enables reV to run directly from filepaths on s3 without HSDS setup. Will be less performant but will require zero setup. Also updated examples and included a test.

@grantbuster grantbuster requested a review from ppinchuk January 10, 2025 15:46
ppinchuk
ppinchuk previously approved these changes Jan 10, 2025
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (7efea50) to head (f94659c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   87.57%   87.62%   +0.04%     
==========================================
  Files         122      122              
  Lines       18234    18249      +15     
==========================================
+ Hits        15969    15991      +22     
+ Misses       2265     2258       -7     
Flag Coverage Δ
unittests 87.62% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grantbuster grantbuster merged commit 68431d3 into main Jan 10, 2025
13 checks passed
@grantbuster grantbuster deleted the gb/revs3 branch January 10, 2025 19:28
github-actions bot pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants