Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cudamapper] Add anchor chain output functions to chainer_utils.cuh. #590
base: dev
Are you sure you want to change the base?
[cudamapper] Add anchor chain output functions to chainer_utils.cuh. #590
Changes from 4 commits
3588962
19040dc
233cfc2
1cc1c25
6680ba6
5860fb1
ef4ce77
2a864de
44bf81d
39f7232
8d7d1ef
756739f
7680371
78da541
44f2f4d
be3b0a4
9f75411
c72e5c9
6df3b76
781c2fd
bd07138
178b075
6244636
d933b4c
b310292
9c65a4b
405ec7e
530adfd
336d02f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is only called by
backtrace_anchors_to_overlaps()
. I understand that it cannot be in an anonymous namespace in order be able to call it form unittest, but it could be moved todetails
namespace in order to signal the users that they do not have to think about itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think creating an overlap from two anchors and a number of residues is useful and could be a user-facing API function, but the function could be better named.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. That's why I was suggesting moving it closed to
Overlap
's definition: #590 (comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I've renamed it to
create_overlap
in c72e5c9.