Prefer Array class over register arrays.

[csarofeen]

Prefer Array class over register arrays.
For example in code generation use Array<float, 2> not float[2].

[csarofeen]

!test

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

⚡ Recommended focus areas for review Logic Change The condition in the if statement has been modified to also check if tv->getMemoryType() == MemoryType::Local. This change may affect the behavior of the function. if (tv && (aligned_array_of_regs_.count(tv) || tv->getMemoryType() == MemoryType::Local)) { Type Change The type of variables T1, T2, and T3 has been changed from float to Array<float, ...>. This change may affect the behavior of the function. Array<float, 1LL, 1> T1; Array<float, 1LL, 1> T2;

[csarofeen]

!test --pybench

[csarofeen]

All tests passing.
Benchmarks do not appear to regress. https://nv/ei9/22766159

[naoyam]

Prefer Array class over register arrays. For example in code generation use Array<float, 2> not float[2].

Any specific reason?

[zasdfgbnm]

Prefer Array class over register arrays. For example in code generation use Array<float, 2> not float[2].

Any specific reason?

Likely because currently we are using float[2] in some cases, but Array<float, 2> in other cases, and sometimes there are compatibility issue for these two types? I remembered Liqiang fixed one such issue on vectorization.

[zasdfgbnm]

Possibly related: #1475

[zasdfgbnm]

Seems that aligned_array_of_regs_ can be removed now.