Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Array class over register arrays. #3737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prefer Array class over register arrays. #3737

wants to merge 1 commit into from

Conversation

csarofeen
Copy link
Collaborator

Prefer Array class over register arrays.
For example in code generation use Array<float, 2> not float[2].

@csarofeen
Copy link
Collaborator Author

!test

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
⚡ Recommended focus areas for review

Logic Change

The condition in the if statement has been modified to also check if tv->getMemoryType() == MemoryType::Local. This change may affect the behavior of the function.

if (tv &&
    (aligned_array_of_regs_.count(tv) ||
     tv->getMemoryType() == MemoryType::Local)) {
Type Change

The type of variables T1, T2, and T3 has been changed from float to Array<float, ...>. This change may affect the behavior of the function.

Array<float, 1LL, 1> T1;
Array<float, 1LL, 1> T2;

@csarofeen
Copy link
Collaborator Author

!test --pybench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant