Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job CLI Upgrade to support path notation #2128

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Job CLI Upgrade to support path notation #2128

merged 2 commits into from
Nov 8, 2023

Conversation

chesterxgchen
Copy link
Collaborator

Description

  1. expand the function to allow key in path format ( dot notation)
  2. add new section on JOB CLI tutorial

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen
1. expand the function to allow key in path format
4f40645 
2. add new section on JOB CLI tutorial
YuanTingHsieh
YuanTingHsieh approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very good fix, we can simplify a lot of job templates.

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit 1f9a7ae into NVIDIA:main Nov 8, 2023
15 checks passed
holgerroth pushed a commit to holgerroth/NVFlare that referenced this pull request Dec 4, 2023
@chesterxgchen
Job CLI Upgrade to support path notation (NVIDIA#2128)
59095f9 
* 1. expand the function to allow key in path format
2. add new section on JOB CLI tutorial

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesterxgchen @YuanTingHsieh