-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to publish metrics to prometheus #2684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesterxgchen
force-pushed
the
sys_metrics
branch
from
July 19, 2024 04:33
e695127
to
a78b5b2
Compare
chesterxgchen
force-pushed
the
sys_metrics
branch
from
August 17, 2024 02:52
a78b5b2
to
43d8656
Compare
chesterxgchen
force-pushed
the
sys_metrics
branch
from
January 4, 2025 04:31
43d8656
to
c58c2f3
Compare
chesterxgchen
force-pushed
the
sys_metrics
branch
from
January 7, 2025 16:31
148994f
to
6f1c51c
Compare
chesterxgchen
force-pushed
the
sys_metrics
branch
from
January 7, 2025 23:22
011f313
to
b454ea3
Compare
IsaacYangSLA
reviewed
Jan 7, 2025
IsaacYangSLA
reviewed
Jan 7, 2025
IsaacYangSLA
reviewed
Jan 7, 2025
/build |
IsaacYangSLA
previously approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated commits.
/build |
/build |
/build |
IsaacYangSLA
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Approving after rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the feature request is to add system metrics to monitoring FLARE running metrics via Prometheus + Grafana or other monitoring systems.
This PR add that missing piece. Here are few pieces to make this work
The SysMetricsCollector listens to the parent process events ( system start/end etc.) for client and server process
The JobMetricsCollector listens to the job process events, mostly related to the job, task etc.
The statsd-reporter post the the metrics received ( from event callback) to the statsd-exporter interface: by default localhost:9125.
StatsD-export expose the :9102/metrics web interface for Prometheus to scrape, which can be used as data source for Grafana to visualize.
These are standard setup. we added an example with docker-compose file to illustrate this process
NVFLARE Monitoring Metrics
These metrics can be separated into Job Metrics and System Metrics. System Metrics are associated with the Client and Server parent processes, while Job Metrics are associated with each job.
We support three different setups:
The detailed examples for setup 1 and 2 are given using hello-pt
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtest.sh
.