Kill subprocess on main thread shutting down #3120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvidianz
requested review from
chesterxgchen,
yhwen,
holgerroth and
ZiyueXu77
|
/build |
|
/build |
yanchengnv
reviewed
Jan 7, 2025
| """ | ||
| try: | ||
| while True: | ||
| if threading._SHUTTING_DOWN: |
There was a problem hiding this comment.
I'm not sure this is a good practice. I googled about the use of SHUTTING_DOWN, and people seem to suggest against using it.
Maybe we should just make sure that all threads set daemon to True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flare API starts several thread pools but it doesn't provide a shutdown/cleanup call.
The user's code doesn't terminate if it errors out. A watch thread is added to kill the
process on shutting down.
Types of changes
./runtest.sh.