Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Fixed the FOBS lazy loading issue #3122

Merged
merged 3 commits into from
Jan 4, 2025
Merged

[2.5] Fixed the FOBS lazy loading issue #3122

merged 3 commits into from
Jan 4, 2025

Conversation

nvidianz
Copy link
Collaborator

Description

FOBS class loader didn't handle lazy-loaded class correctly. So some class can't be found.
It's fixed by using importlib.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvidianz
Copy link
Collaborator Author

/build

SYangster
SYangster approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacYangSLA
Copy link
Collaborator

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (squash) January 4, 2025 01:09
@IsaacYangSLA IsaacYangSLA merged commit e6ae0be into NVIDIA:2.5 Jan 4, 2025
20 checks passed
@nvidianz nvidianz deleted the fix-fobs-lazy-class-loading-2.5 branch January 4, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@holgerroth holgerroth Awaiting requested review from holgerroth

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvidianz @IsaacYangSLA @SYangster