Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic logging with admin commands #3127

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Dynamic logging with admin commands #3127

wants to merge 5 commits into from
+358 −15

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Jan 2, 2025 •
edited
Loading

depends on #3126

  • Add dynamic logging mechanism with options to provide a file, levelname/level for root level, or to reload
  • Add log_config argument for simulator
  • configure_site_log target config under operate command category
  • configure_job_log job_id target config under manage_job command category

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster requested a review from yhwen January 6, 2025 17:52
@SYangster SYangster force-pushed the logging_dynamic branch 2 times, most recently from 24cb747 to 21586dd Compare January 7, 2025 16:43
@SYangster
Copy link
Collaborator Author

/build

yanchengnv
yanchengnv requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the handling of log change command failure. See my comments.
Make sure that command processing returns appropriate result.

nvflare/private/fed/client/admin_commands.py Show resolved Hide resolved
nvflare/private/fed/client/sys_cmd.py Outdated Show resolved Hide resolved
nvflare/private/fed/client/training_cmds.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/job_cmds.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/server_commands.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/server_engine.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/server_engine.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/server_engine.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/server_runner.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/sys_cmd.py Outdated Show resolved Hide resolved
@SYangster SYangster force-pushed the logging_dynamic branch 2 times, most recently from 2ec6f63 to 893addd Compare January 9, 2025 19:16
@SYangster SYangster requested a review from yanchengnv January 9, 2025 19:18
@SYangster
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM

nvflare/fuel/utils/log_utils.py Show resolved Hide resolved
nvflare/private/fed/app/simulator/simulator_runner.py Show resolved Hide resolved
nvflare/private/fed/client/client_executor.py Show resolved Hide resolved
nvflare/private/fed/server/job_cmds.py Outdated Show resolved Hide resolved
nvflare/private/fed/server/server_commands.py Show resolved Hide resolved
nvflare/private/fed/client/admin_commands.py Show resolved Hide resolved
@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

Please improve the handling of log change command failure. See my comments. Make sure that command processing returns appropriate result.

@yanchengnv need approval for "changes requested"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@yhwen yhwen Awaiting requested review from yhwen

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SYangster @chesterxgchen @yhwen @YuanTingHsieh @yanchengnv