Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support connection security and message authentication #3135

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Support connection security and message authentication #3135

merged 6 commits into from
Jan 14, 2025

Conversation

yanchengnv
Copy link
Collaborator

@yanchengnv yanchengnv commented Jan 7, 2025 •
edited
Loading

Fixes # .

Description

This PR implements:

  • Support of different connection security: mTLS, TLS, and clear (insecure)
  • Support of explicit message authentication
  • Refactored job process arg computation to make it easy for different job launchers.

This PR is based on the following PRs for 2.5:

#3105
#3103
#3096
#3062

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nvflare/lighter/impl/static_file.py Show resolved Hide resolved
@yanchengnv
Copy link
Collaborator Author

/build

@yanchengnv
Copy link
Collaborator Author

/build

1 similar comment
@IsaacYangSLA
Copy link
Collaborator

/build

@IsaacYangSLA IsaacYangSLA merged commit 895cffa into NVIDIA:main Jan 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanchengnv @IsaacYangSLA @YuanTingHsieh @nvidianz