Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error log sending to master template and add provisioning configuration #3138

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nvkevlu
Copy link
Collaborator

@nvkevlu nvkevlu commented Jan 10, 2025

Add error log sending to master template and an ability to configure it in provisioning.

Description

Add error log sending to master template and an ability to configure it in provisioning. A new PropKey is expected for allow_error_sending: true to be in the project.yml for a client to allow error log sending. If this is not included, a _modify_error_sender callback added to StaticFileBuilder's build_from_template will remove the error_log_sender component from the client during provisioning.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvkevlu nvkevlu marked this pull request as ready for review January 10, 2025 22:09
@nvkevlu nvkevlu enabled auto-merge (squash) January 10, 2025 22:19
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Jan 10, 2025

/build

1 similar comment
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Jan 13, 2025

/build

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

nvflare/lighter/ctx.py Show resolved Hide resolved
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and check the type/value of "section"

@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Jan 15, 2025

/build

@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Jan 15, 2025

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants