Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate thrust::optional #3307

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Deprecate thrust::optional #3307

merged 10 commits into from
Jan 15, 2025

Conversation

bernhardmgruber
Copy link
Contributor

Fixes: #3306

@bernhardmgruber bernhardmgruber requested review from a team as code owners January 9, 2025 10:49
@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. backport branch/2.8.x labels Jan 9, 2025
miscco
miscco reviewed Jan 9, 2025
View reviewed changes
thrust/thrust/optional.h Outdated Show resolved Hide resolved
thrust/thrust/system/cuda/detail/future.inl Show resolved Hide resolved
@miscco miscco requested a review from a team as a code owner January 9, 2025 12:56
@bernhardmgruber bernhardmgruber force-pushed the depr_optional branch 2 times, most recently from 141e754 to 6a25f66 Compare January 13, 2025 11:17
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bernhardmgruber
Copy link
Contributor Author

/ok to test

@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 2h 00m: Pass: 100%/78 | Total: 15h 25m | Avg: 11m 51s | Max: 39m 58s | Hits: 414%/12340

  • 🟩 cub: Pass: 100%/38 | Total: 7h 35m | Avg: 11m 59s | Max: 35m 49s | Hits: 599%/3120 

    🟩 cpu
  🟩 amd64              Pass: 100%/36  | Total:  7h 26m | Avg: 12m 23s | Max: 35m 49s | Hits: 599%/3120  
  🟩 arm64              Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  4m 47s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 48m 15s | Avg:  9m 39s | Max: 27m 48s | Hits: 599%/780   
  🟩 12.5               Pass: 100%/2   | Total: 18m 17s | Avg:  9m 08s | Max:  9m 14s
  🟩 12.6               Pass: 100%/31  | Total:  6h 29m | Avg: 12m 32s | Max: 35m 49s | Hits: 599%/2340  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  8m 48s | Avg:  4m 24s | Max:  4m 27s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 48m 15s | Avg:  9m 39s | Max: 27m 48s | Hits: 599%/780   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 18m 17s | Avg:  9m 08s | Max:  9m 14s
  🟩 nvcc12.6           Pass: 100%/29  | Total:  6h 20m | Avg: 13m 06s | Max: 35m 49s | Hits: 599%/2340  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  8m 48s | Avg:  4m 24s | Max:  4m 27s
  🟩 nvcc               Pass: 100%/36  | Total:  7h 26m | Avg: 12m 24s | Max: 35m 49s | Hits: 599%/3120  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 20m 54s | Avg:  5m 13s | Max:  5m 26s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 39s | Avg:  5m 39s | Max:  5m 39s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 13s | Avg:  5m 13s | Max:  5m 13s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 13s | Avg:  5m 13s | Max:  5m 13s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 24m | Avg: 12m 01s | Max: 31m 55s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 06s | Avg:  5m 03s | Max:  5m 05s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 14s | Avg:  5m 14s | Max:  5m 14s
  🟩 GCC9               Pass: 100%/2   | Total: 10m 49s | Avg:  5m 24s | Max:  5m 27s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 15s | Avg:  5m 15s | Max:  5m 15s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 23s | Avg:  5m 23s | Max:  5m 23s
  🟩 GCC12              Pass: 100%/3   | Total: 29m 20s | Avg:  9m 46s | Max: 19m 25s
  🟩 GCC13              Pass: 100%/8   | Total:  2h 17m | Avg: 17m 08s | Max: 35m 49s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 56m 28s | Avg: 28m 14s | Max: 28m 40s | Hits: 599%/1560  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 56m 27s | Avg: 28m 13s | Max: 28m 55s | Hits: 599%/1560  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 18m 17s | Avg:  9m 08s | Max:  9m 14s
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  2h 01m | Avg:  8m 39s | Max: 31m 55s
  🟩 GCC                Pass: 100%/18  | Total:  3h 23m | Avg: 11m 17s | Max: 35m 49s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 52m | Avg: 28m 13s | Max: 28m 55s | Hits: 599%/3120  
  🟩 NVHPC              Pass: 100%/2   | Total: 18m 17s | Avg:  9m 08s | Max:  9m 14s
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 23m 52s | Avg: 11m 56s | Max: 19m 25s
  🟩 v100               Pass: 100%/36  | Total:  7h 11m | Avg: 11m 59s | Max: 35m 49s | Hits: 599%/3120  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total:  4h 19m | Avg:  8m 22s | Max: 28m 55s | Hits: 599%/3120  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 25m 29s | Avg: 25m 29s | Max: 25m 29s
  🟩 GraphCapture       Pass: 100%/1   | Total: 35m 49s | Avg: 35m 49s | Max: 35m 49s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 19m | Avg: 26m 27s | Max: 31m 55s
  🟩 TestGPU            Pass: 100%/2   | Total: 55m 14s | Avg: 27m 37s | Max: 28m 00s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 23m 52s | Avg: 11m 56s | Max: 19m 25s
  🟩 90a                Pass: 100%/1   | Total:  4m 22s | Avg:  4m 22s | Max:  4m 22s
🟩 std
  🟩 17                 Pass: 100%/14  | Total:  2h 24m | Avg: 10m 21s | Max: 28m 40s | Hits: 599%/2340  
  🟩 20                 Pass: 100%/24  | Total:  5h 10m | Avg: 12m 56s | Max: 35m 49s | Hits: 599%/780

  • 🟩 thrust: Pass: 100%/37 | Total: 7h 11m | Avg: 11m 39s | Max: 39m 58s | Hits: 351%/9220 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 19m 06s | Avg:  9m 33s | Max: 13m 04s
🟩 cpu
  🟩 amd64              Pass: 100%/35  | Total:  7h 01m | Avg: 12m 02s | Max: 39m 58s | Hits: 351%/9220  
  🟩 arm64              Pass: 100%/2   | Total:  9m 51s | Avg:  4m 55s | Max:  5m 06s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 49m 21s | Avg:  9m 52s | Max: 28m 45s | Hits: 348%/1844  
  🟩 12.5               Pass: 100%/2   | Total: 42m 46s | Avg: 21m 23s | Max: 22m 10s
  🟩 12.6               Pass: 100%/30  | Total:  5h 39m | Avg: 11m 18s | Max: 39m 58s | Hits: 352%/7376  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  5m 10s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 49m 21s | Avg:  9m 52s | Max: 28m 45s | Hits: 348%/1844  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 42m 46s | Avg: 21m 23s | Max: 22m 10s
  🟩 nvcc12.6           Pass: 100%/28  | Total:  5h 29m | Avg: 11m 45s | Max: 39m 58s | Hits: 352%/7376  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  5m 10s
  🟩 nvcc               Pass: 100%/35  | Total:  7h 01m | Avg: 12m 02s | Max: 39m 58s | Hits: 351%/9220  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 10s | Avg:  5m 17s | Max:  5m 25s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 53s | Avg:  5m 53s | Max:  5m 53s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 21s | Avg:  5m 21s | Max:  5m 21s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 15s | Avg:  5m 15s | Max:  5m 15s
  🟩 Clang18            Pass: 100%/7   | Total: 47m 02s | Avg:  6m 43s | Max: 14m 12s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 24s | Avg:  5m 12s | Max:  5m 20s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 23s | Avg:  5m 23s | Max:  5m 23s
  🟩 GCC9               Pass: 100%/2   | Total: 10m 41s | Avg:  5m 20s | Max:  5m 31s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 55s | Avg:  5m 55s | Max:  5m 55s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 36s | Avg:  5m 36s | Max:  5m 36s
  🟩 GCC12              Pass: 100%/1   | Total:  5m 34s | Avg:  5m 34s | Max:  5m 34s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 37m | Avg: 12m 13s | Max: 39m 58s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 59m 26s | Avg: 29m 43s | Max: 30m 41s | Hits: 348%/3688  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  1h 43m | Avg: 34m 26s | Max: 38m 42s | Hits: 354%/5532  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 42m 46s | Avg: 21m 23s | Max: 22m 10s
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  1h 24m | Avg:  6m 02s | Max: 14m 12s
  🟩 GCC                Pass: 100%/16  | Total:  2h 21m | Avg:  8m 49s | Max: 39m 58s
  🟩 MSVC               Pass: 100%/5   | Total:  2h 42m | Avg: 32m 33s | Max: 38m 42s | Hits: 351%/9220  
  🟩 NVHPC              Pass: 100%/2   | Total: 42m 46s | Avg: 21m 23s | Max: 22m 10s
🟩 gpu
  🟩 v100               Pass: 100%/37  | Total:  7h 11m | Avg: 11m 39s | Max: 39m 58s | Hits: 351%/9220  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total:  5h 38m | Avg: 10m 54s | Max: 39m 58s | Hits: 348%/7376  
  🟩 TestCPU            Pass: 100%/3   | Total: 53m 32s | Avg: 17m 50s | Max: 38m 42s | Hits: 365%/1844  
  🟩 TestGPU            Pass: 100%/3   | Total: 39m 57s | Avg: 13m 19s | Max: 14m 12s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  7m 10s | Avg:  7m 10s | Max:  7m 10s
🟩 std
  🟩 17                 Pass: 100%/14  | Total:  3h 21m | Avg: 14m 22s | Max: 39m 58s | Hits: 348%/5532  
  🟩 20                 Pass: 100%/21  | Total:  3h 31m | Avg: 10m 03s | Max: 38m 42s | Hits: 356%/3688

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 8m 54s | Avg: 4m 27s | Max: 6m 54s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  8m 54s | Avg:  4m 27s | Max:  6m 54s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 00s | Avg:  2m 00s | Max:  2m 00s
  🟩 Test               Pass: 100%/1   | Total:  6m 54s | Avg:  6m 54s | Max:  6m 54s

  • 🟩 python: Pass: 100%/1 | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 78)
# Runner
53 linux-amd64-cpu16
11 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16
4 linux-arm64-cpu16
1 linux-amd64-gpu-h100-latest-1-testing

@bernhardmgruber bernhardmgruber merged commit 7f3878a into NVIDIA:main Jan 15, 2025
93 checks passed
@bernhardmgruber bernhardmgruber deleted the depr_optional branch January 15, 2025 10:47
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for branch/2.8.x with exitcode 128

bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this pull request Jan 15, 2025
@bernhardmgruber
Deprecate thrust::optional (NVIDIA#3307)
a7e05f7 
Fixes: NVIDIA#3306
bernhardmgruber added a commit that referenced this pull request Jan 15, 2025
@bernhardmgruber
Deprecate thrust::optional (#3307) (#3393)
5ebc18c 
Fixes: #3306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
backport branch/2.8.x thrust For all items related to Thrust.
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate thrust::optional
2 participants
@bernhardmgruber @miscco