-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken _CCCL_BUILTIN_ASSUME
macro
#3314
base: main
Are you sure you want to change the base?
Conversation
Why don't we just implement the [[assume]] attribute as _CCCL_ASSUME(...) instead of a builtin? We could use the C++ native attribute if available and fallback to compiler specific builtins |
🟩 CI finished in 2h 01m: Pass: 100%/144 | Total: 3d 01h | Avg: 30m 28s | Max: 1h 19m | Hits: 219%/25164
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 144)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
19 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really a bit torn here. compiler support is still very sketchy for that and if I remember correctly there were even some pessimization when using that
@davebayer I like the idea!
I agree related to host compilers, while for device code, assumptions can be pretty useful for optimizations. |
🟨 CI finished in 1h 51m: Pass: 99%/144 | Total: 1d 11h | Avg: 14m 55s | Max: 1h 11m | Hits: 250%/25164
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 144)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
19 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
🟩 CI finished in 3h 03m: Pass: 100%/144 | Total: 1d 11h | Avg: 14m 52s | Max: 1h 11m | Hits: 250%/25164
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 144)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
19 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
Description
__builtin_assume
was not recognized by any compiler. The PR adds specific paths for all supported compilers.