refactor <cuda/std/cstdlib>
#3339
Open
+270
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Jan 15, 2025
Comment on lines
+53
to
+67
| #if _CCCL_STD_VER >= 2017 && !_CCCL_COMPILER(MSVC) | ||
| # define _LIBCUDACXX_HAS_ALIGNED_ALLOC_HOST 1 | ||
| # define _LIBCUDACXX_ALIGNED_ALLOC_HOST _CCCL_HOST | ||
| #else | ||
| # define _LIBCUDACXX_ALIGNED_ALLOC_HOST | ||
| #endif // _CCCL_STD_VER >= 2017 && !_CCCL_COMPILER(MSVC) | ||
|
|
||
| #if _CCCL_HAS_CUDA_COMPILER && !_CCCL_CUDA_COMPILER(CLANG) | ||
| # define _LIBCUDACXX_HAS_ALIGNED_ALLOC_DEVICE 1 | ||
| # define _LIBCUDACXX_ALIGNED_ALLOC_DEVICE _CCCL_DEVICE | ||
| #else | ||
| # define _LIBCUDACXX_ALIGNED_ALLOC_DEVICE | ||
| #endif // _CCCL_HAS_CUDA_COMPILER && !_CCCL_CUDA_COMPILER(CLANG) | ||
|
|
||
| #define _LIBCUDACXX_ALIGNED_ALLOC_EXSPACE _LIBCUDACXX_ALIGNED_ALLOC_HOST _LIBCUDACXX_ALIGNED_ALLOC_DEVICE |
There was a problem hiding this comment.
Can you elaborate what the issue is here?
Shouldnt this rather be a _CCCL_EXECK_CHECK_DISABLE?
There was a problem hiding this comment.
The problem is quite simple, to use aligned_alloc
- on host, we need C++17, but MSVC does not implement that at all
- on device, we need support for
__nv_aligned_device_malloc, which I did not a way to make it work with clang-cuda
Using _CCCL_EXECK_CHECK_DISABLE would probably solve the issue, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements refactor of
<cuda/std/cstdlib>.Changes:
__host__only, such asexitoratofmalloc-related functions to<cuda/std/__cstdlib/malloc.h>modulecallocandaligned_allocfor__device__