-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review CUB util.ptx
for CCCL 2.x
#3342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the shift and a typo, LGTM
🟨 CI finished in 3h 04m: Pass: 97%/78 | Total: 2d 06h | Avg: 41m 41s | Max: 1h 37m | Hits: 216%/12368
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 78)
# | Runner |
---|---|
53 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
fbusato
force-pushed
the
review-cub-util-ptx
branch
from
January 13, 2025 23:07
96cf032
to
8d44adb
Compare
🟨 CI finished in 3h 35m: Pass: 97%/78 | Total: 2d 04h | Avg: 40m 43s | Max: 1h 15m | Hits: 189%/12340
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 78)
# | Runner |
---|---|
53 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
fbusato
force-pushed
the
review-cub-util-ptx
branch
from
January 14, 2025 18:41
ee86833
to
3cf9263
Compare
Signed-off-by: fbusato <[email protected]>
Signed-off-by: fbusato <[email protected]>
fbusato
force-pushed
the
review-cub-util-ptx
branch
from
January 14, 2025 19:01
3cf9263
to
ffe65ca
Compare
🟩 CI finished in 2h 36m: Pass: 100%/78 | Total: 2d 05h | Avg: 41m 26s | Max: 1h 16m | Hits: 187%/12340
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 78)
# | Runner |
---|---|
53 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
bernhardmgruber
approved these changes
Jan 15, 2025
Git push to origin failed for branch/2.8.x with exitcode 128 |
bernhardmgruber
pushed a commit
to bernhardmgruber/cccl
that referenced
this pull request
Jan 15, 2025
miscco
pushed a commit
that referenced
this pull request
Jan 15, 2025
Co-authored-by: Federico Busato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3289
Description
BFI
,IADD3
,PRMT
,BAR
,FMUL_RZ
,FFMA_RZ
,ThreadTrap
because never useddetail
namespace) with standard shift operations, which could be beneficial for NVVM optimizations