[DO NOT MERGE] [CUDAX] <cuda/experimental/file> proposal
#3360
+1,106
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
davebayer
commented
Jan 12, 2025
| __handle_ = detail::__cufile_handle_register(&__descr); | ||
| } | ||
|
|
||
| ::std::FILE* __file_{}; |
There was a problem hiding this comment.
I am not sure if using FILE is the right solution, maybe it would be better to implement the class as a wrapper around the native handle.
Comment on lines
+39
to
+56
| struct property | ||
| { | ||
| // Prop obj 1 | ||
| // Prop obj 2 | ||
| // ... | ||
| }; | ||
|
|
||
| template <class Prop> | ||
| auto get(const Prop& prop) | ||
| { | ||
| return prop.get(); | ||
| } | ||
|
|
||
| template <class Prop> | ||
| void set(const Prop& prop, ::cuda::std::type_identity_t<typename Prop::value_type> value) | ||
| { | ||
| prop.set(value); | ||
| } |
There was a problem hiding this comment.
This would be implemented the same way as e. g. device attributes.
Comment on lines
+24
to
+26
| #if !_CCCL_OS(LINUX) | ||
| # error "<cuda/experimental/file> is only supported on Linux." | ||
| #endif // _CCCL_OS(LINUX) |
There was a problem hiding this comment.
cuFile does not support other platforms than Linux for now.
Comment on lines
+212
to
+213
| auto __error = | ||
| ::cudaLaunchHostFunc(__stream, ::cuda::experimental::detail::__check_cufile_read_async_error, __nbytes_read_ptr); |
There was a problem hiding this comment.
The problem is that cuFileReadAsync returns any error in the __nbytes_read_ptr variable, so I run a host function that will throw if a cuFile error occures.
Comment on lines
+251
to
+252
| auto __error = ::cudaLaunchHostFunc( | ||
| __stream, ::cuda::experimental::detail::__check_cufile_write_async_error, __nbytes_written_ptr); |
There was a problem hiding this comment.
The same story as for the async read.
davebayer
changed the title
<cuda/experimental/file><cuda/experimental/file> proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3359.