Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable automatic header inclusion for clangd #3365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable automatic header inclusion for clangd #3365

wants to merge 1 commit into from

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Jan 13, 2025

This commonly silently adds wrong relative includes at the wrong places

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@miscco
Disable automatic header inclusion for clangd
2e4ed35 
This commonly silently adds wrong relative includes at the wrong places
@miscco miscco force-pushed the disable_clangd_header_include branch from fba66d3 to 2e4ed35 Compare January 13, 2025 10:58
@miscco miscco marked this pull request as ready for review January 13, 2025 11:44
@miscco miscco requested review from a team as code owners January 13, 2025 11:44
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 2h 06m: Pass: 100%/148 | Total: 1d 20h | Avg: 17m 54s | Max: 1h 26m | Hits: 544%/25112

  • 🟩 libcudacxx: Pass: 100%/46 | Total: 7h 54m | Avg: 10m 19s | Max: 31m 12s | Hits: 682%/12472 

    🟩 cpu
  🟩 amd64              Pass: 100%/44  | Total:  7h 47m | Avg: 10m 37s | Max: 31m 12s | Hits: 682%/12472 
  🟩 arm64              Pass: 100%/2   | Total:  6m 51s | Avg:  3m 25s | Max:  3m 36s
🟩 ctk
  🟩 12.0               Pass: 100%/8   | Total:  1h 02m | Avg:  7m 49s | Max: 23m 40s | Hits: 682%/4869  
  🟩 12.5               Pass: 100%/2   | Total: 16m 58s | Avg:  8m 29s | Max:  8m 39s
  🟩 12.6               Pass: 100%/36  | Total:  6h 35m | Avg: 10m 58s | Max: 31m 12s | Hits: 682%/7603  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  1h 09m | Avg: 17m 18s | Max: 22m 07s
  🟩 nvcc12.0           Pass: 100%/8   | Total:  1h 02m | Avg:  7m 49s | Max: 23m 40s | Hits: 682%/4869  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 16m 58s | Avg:  8m 29s | Max:  8m 39s
  🟩 nvcc12.6           Pass: 100%/32  | Total:  5h 25m | Avg: 10m 11s | Max: 31m 12s | Hits: 682%/7603  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total:  1h 09m | Avg: 17m 18s | Max: 22m 07s
  🟩 nvcc               Pass: 100%/42  | Total:  6h 45m | Avg:  9m 39s | Max: 31m 12s | Hits: 682%/12472 
🟩 cxx
  🟩 Clang14            Pass: 100%/6   | Total: 22m 47s | Avg:  3m 47s | Max:  4m 23s
  🟩 Clang15            Pass: 100%/1   | Total:  4m 23s | Avg:  4m 23s | Max:  4m 23s
  🟩 Clang16            Pass: 100%/1   | Total:  4m 29s | Avg:  4m 29s | Max:  4m 29s
  🟩 Clang17            Pass: 100%/1   | Total:  4m 28s | Avg:  4m 28s | Max:  4m 28s
  🟩 Clang18            Pass: 100%/8   | Total:  1h 41m | Avg: 12m 43s | Max: 22m 07s
  🟩 GCC7               Pass: 100%/5   | Total: 16m 31s | Avg:  3m 18s | Max:  3m 44s
  🟩 GCC8               Pass: 100%/1   | Total:  3m 44s | Avg:  3m 44s | Max:  3m 44s
  🟩 GCC9               Pass: 100%/3   | Total:  9m 57s | Avg:  3m 19s | Max:  3m 48s
  🟩 GCC10              Pass: 100%/1   | Total: 18m 31s | Avg: 18m 31s | Max: 18m 31s
  🟩 GCC11              Pass: 100%/1   | Total:  3m 53s | Avg:  3m 53s | Max:  3m 53s
  🟩 GCC12              Pass: 100%/1   | Total:  3m 58s | Avg:  3m 58s | Max:  3m 58s
  🟩 GCC13              Pass: 100%/10  | Total:  2h 24m | Avg: 14m 25s | Max: 31m 12s
  🟩 MSVC14.29          Pass: 100%/3   | Total:  1h 07m | Avg: 22m 24s | Max: 23m 54s | Hits: 683%/7354  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 51m 45s | Avg: 25m 52s | Max: 26m 29s | Hits: 682%/5118  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 16m 58s | Avg:  8m 29s | Max:  8m 39s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 17m | Avg:  8m 06s | Max: 22m 07s
  🟩 GCC                Pass: 100%/22  | Total:  3h 20m | Avg:  9m 07s | Max: 31m 12s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 58m | Avg: 23m 47s | Max: 26m 29s | Hits: 682%/12472 
  🟩 NVHPC              Pass: 100%/2   | Total: 16m 58s | Avg:  8m 29s | Max:  8m 39s
🟩 gpu
  🟩 v100               Pass: 100%/46  | Total:  7h 54m | Avg: 10m 19s | Max: 31m 12s | Hits: 682%/12472 
🟩 jobs
  🟩 Build              Pass: 100%/39  | Total:  5h 25m | Avg:  8m 20s | Max: 26m 29s | Hits: 682%/12472 
  🟩 NVRTC              Pass: 100%/4   | Total:  1h 48m | Avg: 27m 01s | Max: 31m 12s
  🟩 Test               Pass: 100%/2   | Total: 39m 32s | Avg: 19m 46s | Max: 20m 14s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 54s | Avg:  1m 54s | Max:  1m 54s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total: 13m 42s | Avg: 13m 42s | Max: 13m 42s
  🟩 90a                Pass: 100%/2   | Total: 17m 16s | Avg:  8m 38s | Max: 13m 43s
🟩 std
  🟩 11                 Pass: 100%/6   | Total: 38m 08s | Avg:  6m 21s | Max: 22m 37s
  🟩 14                 Pass: 100%/4   | Total: 50m 24s | Avg: 12m 36s | Max: 23m 25s | Hits: 682%/2394  
  🟩 17                 Pass: 100%/14  | Total:  2h 42m | Avg: 11m 36s | Max: 31m 12s | Hits: 683%/7445  
  🟩 20                 Pass: 100%/21  | Total:  3h 41m | Avg: 10m 33s | Max: 30m 52s | Hits: 682%/2633

  • 🟩 cub: Pass: 100%/38 | Total: 23h 27m | Avg: 37m 03s | Max: 1h 26m | Hits: 591%/3108 

    🟩 cpu
  🟩 amd64              Pass: 100%/36  | Total: 22h 05m | Avg: 36m 49s | Max:  1h 26m | Hits: 591%/3108  
  🟩 arm64              Pass: 100%/2   | Total:  1h 22m | Avg: 41m 09s | Max: 41m 17s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 18m | Avg: 39m 43s | Max: 50m 08s | Hits: 575%/777   
  🟩 12.5               Pass: 100%/2   | Total:  1h 32m | Avg: 46m 26s | Max: 48m 14s
  🟩 12.6               Pass: 100%/31  | Total: 18h 36m | Avg: 36m 00s | Max:  1h 26m | Hits: 597%/2331  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 42m | Avg: 51m 15s | Max: 51m 36s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 18m | Avg: 39m 43s | Max: 50m 08s | Hits: 575%/777   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 32m | Avg: 46m 26s | Max: 48m 14s
  🟩 nvcc12.6           Pass: 100%/29  | Total: 16h 53m | Avg: 34m 57s | Max:  1h 26m | Hits: 597%/2331  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 42m | Avg: 51m 15s | Max: 51m 36s
  🟩 nvcc               Pass: 100%/36  | Total: 21h 45m | Avg: 36m 15s | Max:  1h 26m | Hits: 591%/3108  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 26m | Avg: 36m 31s | Max: 37m 54s
  🟩 Clang15            Pass: 100%/1   | Total: 36m 31s | Avg: 36m 31s | Max: 36m 31s
  🟩 Clang16            Pass: 100%/1   | Total: 34m 41s | Avg: 34m 41s | Max: 34m 41s
  🟩 Clang17            Pass: 100%/1   | Total: 34m 04s | Avg: 34m 04s | Max: 34m 04s
  🟩 Clang18            Pass: 100%/7   | Total:  4h 25m | Avg: 37m 58s | Max: 51m 36s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 16m | Avg: 38m 16s | Max: 39m 27s
  🟩 GCC8               Pass: 100%/1   | Total: 35m 49s | Avg: 35m 49s | Max: 35m 49s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 11m | Avg: 35m 52s | Max: 36m 06s
  🟩 GCC10              Pass: 100%/1   | Total: 36m 08s | Avg: 36m 08s | Max: 36m 08s
  🟩 GCC11              Pass: 100%/1   | Total: 36m 46s | Avg: 36m 46s | Max: 36m 46s
  🟩 GCC12              Pass: 100%/3   | Total: 55m 49s | Avg: 18m 36s | Max: 35m 41s
  🟩 GCC13              Pass: 100%/8   | Total:  4h 47m | Avg: 35m 53s | Max:  1h 26m
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 38m | Avg: 49m 07s | Max: 50m 08s | Hits: 586%/1554  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 39m | Avg: 49m 50s | Max: 51m 33s | Hits: 596%/1554  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 32m | Avg: 46m 26s | Max: 48m 14s
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  8h 37m | Avg: 36m 56s | Max: 51m 36s
  🟩 GCC                Pass: 100%/18  | Total:  9h 59m | Avg: 33m 19s | Max:  1h 26m
  🟩 MSVC               Pass: 100%/4   | Total:  3h 17m | Avg: 49m 28s | Max: 51m 33s | Hits: 591%/3108  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 32m | Avg: 46m 26s | Max: 48m 14s
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 20m 08s | Avg: 10m 04s | Max: 16m 02s
  🟩 v100               Pass: 100%/36  | Total: 23h 07m | Avg: 38m 32s | Max:  1h 26m | Hits: 591%/3108  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total: 19h 30m | Avg: 37m 45s | Max: 51m 36s | Hits: 591%/3108  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 33m 20s | Avg: 33m 20s | Max: 33m 20s
  🟩 GraphCapture       Pass: 100%/1   | Total: 20m 27s | Avg: 20m 27s | Max: 20m 27s
  🟩 HostLaunch         Pass: 100%/3   | Total:  2h 03m | Avg: 41m 19s | Max:  1h 26m
  🟩 TestGPU            Pass: 100%/2   | Total: 59m 35s | Avg: 29m 47s | Max: 29m 55s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 20m 08s | Avg: 10m 04s | Max: 16m 02s
  🟩 90a                Pass: 100%/1   | Total:  4m 24s | Avg:  4m 24s | Max:  4m 24s
🟩 std
  🟩 17                 Pass: 100%/14  | Total:  9h 32m | Avg: 40m 54s | Max: 51m 36s | Hits: 590%/2331  
  🟩 20                 Pass: 100%/24  | Total: 13h 55m | Avg: 34m 47s | Max:  1h 26m | Hits: 596%/777

  • 🟩 thrust: Pass: 100%/37 | Total: 9h 48m | Avg: 15m 53s | Max: 42m 00s | Hits: 340%/9220 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 40m 29s | Avg: 20m 14s | Max: 30m 52s
🟩 cpu
  🟩 amd64              Pass: 100%/35  | Total:  9h 27m | Avg: 16m 13s | Max: 42m 00s | Hits: 340%/9220  
  🟩 arm64              Pass: 100%/2   | Total: 20m 13s | Avg: 10m 06s | Max: 10m 51s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 14m | Avg: 14m 53s | Max: 32m 56s | Hits: 344%/1844  
  🟩 12.5               Pass: 100%/2   | Total:  1h 10m | Avg: 35m 15s | Max: 35m 39s
  🟩 12.6               Pass: 100%/30  | Total:  7h 23m | Avg: 14m 46s | Max: 42m 00s | Hits: 339%/7376  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 20m 21s | Avg: 10m 10s | Max: 10m 32s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 14m | Avg: 14m 53s | Max: 32m 56s | Hits: 344%/1844  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 10m | Avg: 35m 15s | Max: 35m 39s
  🟩 nvcc12.6           Pass: 100%/28  | Total:  7h 02m | Avg: 15m 06s | Max: 42m 00s | Hits: 339%/7376  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 20m 21s | Avg: 10m 10s | Max: 10m 32s
  🟩 nvcc               Pass: 100%/35  | Total:  9h 27m | Avg: 16m 13s | Max: 42m 00s | Hits: 340%/9220  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 43m 20s | Avg: 10m 50s | Max: 11m 01s
  🟩 Clang15            Pass: 100%/1   | Total: 10m 22s | Avg: 10m 22s | Max: 10m 22s
  🟩 Clang16            Pass: 100%/1   | Total: 11m 04s | Avg: 11m 04s | Max: 11m 04s
  🟩 Clang17            Pass: 100%/1   | Total: 10m 20s | Avg: 10m 20s | Max: 10m 20s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 13m | Avg: 10m 28s | Max: 16m 03s
  🟩 GCC7               Pass: 100%/2   | Total: 20m 18s | Avg: 10m 09s | Max: 11m 07s
  🟩 GCC8               Pass: 100%/1   | Total: 10m 43s | Avg: 10m 43s | Max: 10m 43s
  🟩 GCC9               Pass: 100%/2   | Total: 20m 53s | Avg: 10m 26s | Max: 10m 38s
  🟩 GCC10              Pass: 100%/1   | Total: 11m 01s | Avg: 11m 01s | Max: 11m 01s
  🟩 GCC11              Pass: 100%/1   | Total: 12m 12s | Avg: 12m 12s | Max: 12m 12s
  🟩 GCC12              Pass: 100%/1   | Total: 11m 21s | Avg: 11m 21s | Max: 11m 21s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 44m | Avg: 13m 02s | Max: 30m 52s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 06m | Avg: 33m 01s | Max: 33m 07s | Hits: 333%/3688  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  1h 52m | Avg: 37m 27s | Max: 42m 00s | Hits: 345%/5532  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 10m | Avg: 35m 15s | Max: 35m 39s
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  2h 28m | Avg: 10m 36s | Max: 16m 03s
  🟩 GCC                Pass: 100%/16  | Total:  3h 10m | Avg: 11m 55s | Max: 30m 52s
  🟩 MSVC               Pass: 100%/5   | Total:  2h 58m | Avg: 35m 41s | Max: 42m 00s | Hits: 340%/9220  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 10m | Avg: 35m 15s | Max: 35m 39s
🟩 gpu
  🟩 v100               Pass: 100%/37  | Total:  9h 48m | Avg: 15m 53s | Max: 42m 00s | Hits: 340%/9220  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total:  7h 54m | Avg: 15m 17s | Max: 42m 00s | Hits: 334%/7376  
  🟩 TestCPU            Pass: 100%/3   | Total: 50m 51s | Avg: 16m 57s | Max: 35m 57s | Hits: 365%/1844  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 03m | Avg: 21m 00s | Max: 30m 52s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  7m 04s | Avg:  7m 04s | Max:  7m 04s
🟩 std
  🟩 17                 Pass: 100%/14  | Total:  4h 00m | Avg: 17m 12s | Max: 34m 51s | Hits: 336%/5532  
  🟩 20                 Pass: 100%/21  | Total:  5h 06m | Avg: 14m 36s | Max: 42m 00s | Hits: 345%/3688

  • 🟩 cudax: Pass: 100%/20 | Total: 2h 00m | Avg: 6m 02s | Max: 22m 00s | Hits: 582%/312 

    🟩 cpu
  🟩 amd64              Pass: 100%/16  | Total:  1h 48m | Avg:  6m 47s | Max: 22m 00s | Hits: 582%/312   
  🟩 arm64              Pass: 100%/4   | Total: 12m 14s | Avg:  3m 03s | Max:  3m 09s
🟩 ctk
  🟩 12.0               Pass: 100%/1   | Total: 10m 22s | Avg: 10m 22s | Max: 10m 22s | Hits: 582%/156   
  🟩 12.5               Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 16s
  🟩 12.6               Pass: 100%/17  | Total:  1h 40m | Avg:  5m 53s | Max: 22m 00s | Hits: 582%/156   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/1   | Total: 10m 22s | Avg: 10m 22s | Max: 10m 22s | Hits: 582%/156   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 16s
  🟩 nvcc12.6           Pass: 100%/17  | Total:  1h 40m | Avg:  5m 53s | Max: 22m 00s | Hits: 582%/156   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/20  | Total:  2h 00m | Avg:  6m 02s | Max: 22m 00s | Hits: 582%/312   
🟩 cxx
  🟩 Clang14            Pass: 100%/1   | Total:  3m 35s | Avg:  3m 35s | Max:  3m 35s
  🟩 Clang15            Pass: 100%/1   | Total:  3m 41s | Avg:  3m 41s | Max:  3m 41s
  🟩 Clang16            Pass: 100%/1   | Total:  4m 01s | Avg:  4m 01s | Max:  4m 01s
  🟩 Clang17            Pass: 100%/1   | Total:  3m 38s | Avg:  3m 38s | Max:  3m 38s
  🟩 Clang18            Pass: 100%/4   | Total: 29m 01s | Avg:  7m 15s | Max: 19m 08s
  🟩 GCC10              Pass: 100%/1   | Total:  3m 40s | Avg:  3m 40s | Max:  3m 40s
  🟩 GCC11              Pass: 100%/1   | Total:  3m 33s | Avg:  3m 33s | Max:  3m 33s
  🟩 GCC12              Pass: 100%/2   | Total: 25m 48s | Avg: 12m 54s | Max: 22m 00s
  🟩 GCC13              Pass: 100%/4   | Total: 12m 10s | Avg:  3m 02s | Max:  3m 05s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 22s | Avg: 10m 22s | Max: 10m 22s | Hits: 582%/156   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 57s | Avg: 10m 57s | Max: 10m 57s | Hits: 582%/156   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 16s
🟩 cxx_family
  🟩 Clang              Pass: 100%/8   | Total: 43m 56s | Avg:  5m 29s | Max: 19m 08s
  🟩 GCC                Pass: 100%/8   | Total: 45m 11s | Avg:  5m 38s | Max: 22m 00s
  🟩 MSVC               Pass: 100%/2   | Total: 21m 19s | Avg: 10m 39s | Max: 10m 57s | Hits: 582%/312   
  🟩 NVHPC              Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 16s
🟩 gpu
  🟩 v100               Pass: 100%/20  | Total:  2h 00m | Avg:  6m 02s | Max: 22m 00s | Hits: 582%/312   
🟩 jobs
  🟩 Build              Pass: 100%/18  | Total:  1h 19m | Avg:  4m 25s | Max: 10m 57s | Hits: 582%/312   
  🟩 Test               Pass: 100%/2   | Total: 41m 08s | Avg: 20m 34s | Max: 22m 00s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  3m 05s | Avg:  3m 05s | Max:  3m 05s
  🟩 90a                Pass: 100%/1   | Total:  3m 04s | Avg:  3m 04s | Max:  3m 04s
🟩 std
  🟩 17                 Pass: 100%/4   | Total: 14m 23s | Avg:  3m 35s | Max:  5m 16s
  🟩 20                 Pass: 100%/16  | Total:  1h 46m | Avg:  6m 39s | Max: 22m 00s | Hits: 582%/312

  • 🟩 cccl: Pass: 100%/4 | Total: 22m 18s | Avg: 5m 34s | Max: 6m 20s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/4   | Total: 22m 18s | Avg:  5m 34s | Max:  6m 20s
🟩 ctk
  🟩 12.0               Pass: 100%/2   | Total: 11m 33s | Avg:  5m 46s | Max:  6m 20s
  🟩 12.6               Pass: 100%/2   | Total: 10m 45s | Avg:  5m 22s | Max:  5m 24s
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/2   | Total: 11m 33s | Avg:  5m 46s | Max:  6m 20s
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 45s | Avg:  5m 22s | Max:  5m 24s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/4   | Total: 22m 18s | Avg:  5m 34s | Max:  6m 20s
🟩 cxx
  🟩 Clang14            Pass: 100%/1   | Total:  6m 20s | Avg:  6m 20s | Max:  6m 20s
  🟩 Clang18            Pass: 100%/1   | Total:  5m 24s | Avg:  5m 24s | Max:  5m 24s
  🟩 GCC12              Pass: 100%/1   | Total:  5m 13s | Avg:  5m 13s | Max:  5m 13s
  🟩 GCC13              Pass: 100%/1   | Total:  5m 21s | Avg:  5m 21s | Max:  5m 21s
🟩 cxx_family
  🟩 Clang              Pass: 100%/2   | Total: 11m 44s | Avg:  5m 52s | Max:  6m 20s
  🟩 GCC                Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  5m 21s
🟩 gpu
  🟩 v100               Pass: 100%/4   | Total: 22m 18s | Avg:  5m 34s | Max:  6m 20s
🟩 jobs
  🟩 Infra              Pass: 100%/4   | Total: 22m 18s | Avg:  5m 34s | Max:  6m 20s

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 24s | Avg: 4m 42s | Max: 7m 22s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 24s | Avg:  4m 42s | Max:  7m 22s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 02s | Avg:  2m 02s | Max:  2m 02s
  🟩 Test               Pass: 100%/1   | Total:  7m 22s | Avg:  7m 22s | Max:  7m 22s

  • 🟩 python: Pass: 100%/1 | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 27m 10s | Avg: 27m 10s | Max: 27m 10s

👃 Inspect Changes

Modifications in project?

Project
+/- CCCL Infrastructure
libcu++
CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
+/- CCCL Infrastructure
+/- libcu++
+/- CUB
+/- Thrust
+/- CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 148)
# Runner
98 linux-amd64-cpu16
23 linux-amd64-gpu-v100-latest-1
16 windows-amd64-cpu16
10 linux-arm64-cpu16
1 linux-amd64-gpu-h100-latest-1-testing

@bernhardmgruber bernhardmgruber removed their request for review January 13, 2025 14:14
bernhardmgruber
bernhardmgruber reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like somebody else to share their opinion on this. CLion also adds headers for me and I find that convenient. If it guessed wrongly, I can fix it. We can also detect bad includes later during review as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber left review comments

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from NVIDIA/cccl-infra-codeowners

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miscco @bernhardmgruber