Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace typedef with using in libcu++ #3368

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Replace typedef with using in libcu++ #3368

wants to merge 18 commits into from
+743 −745

Conversation

davebayer
Copy link
Contributor

This PR replaces all typedefs with modern using syntax in all "alive" headers in libcu++.

@davebayer davebayer requested review from a team as code owners January 13, 2025 15:46
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco
Copy link
Collaborator

miscco commented Jan 13, 2025

/ok to test

@bernhardmgruber
Copy link
Contributor

This addresses the remaining part of: #1747

@davebayer
Copy link
Contributor Author

@bernhardmgruber I've replace the typedefs only in the headers, not e. g. in the test files. Should I replace them in the other parts of libcu++ as well?

@miscco
Copy link
Collaborator

miscco commented Jan 14, 2025

@bernhardmgruber I've replace the typedefs only in the headers, not e. g. in the test files. Should I replace them in the other parts of libcu++ as well?

ltes start with production code first then go to other stuff

@miscco
Copy link
Collaborator

miscco commented Jan 15, 2025

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@fbusato fbusato Awaiting requested review from fbusato fbusato is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

@bernhardmgruber bernhardmgruber Awaiting requested review from bernhardmgruber bernhardmgruber is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davebayer @miscco @bernhardmgruber