Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to 2.8: Deprecate thrust::async (#3324) #3388

Open
wants to merge 1 commit into
base: branch/2.8.x
Choose a base branch
from
Open

Backport to 2.8: Deprecate thrust::async (#3324) #3388

wants to merge 1 commit into from
+321 −233

Conversation

bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Jan 15, 2025 •
edited
Loading

No description provided.

@bernhardmgruber bernhardmgruber requested review from a team as code owners January 15, 2025 00:15
@github-actions GitHub Actions
Copy link
Contributor

🟨 CI finished in 1h 30m: Pass: 97%/96 | Total: 18h 46m | Avg: 11m 44s | Max: 48m 18s | Hits: 417%/12392

  • 🟨 thrust: Pass: 95%/46 | Total: 9h 35m | Avg: 12m 30s | Max: 38m 00s | Hits: 356%/9260 

    🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  95%/44  | Total:  9h 15m | Avg: 12m 37s | Max: 38m 00s | Hits: 356%/9260  
  🟩 arm64              Pass: 100%/2   | Total: 20m 26s | Avg: 10m 13s | Max: 11m 10s
🔍 ctk: 11.1 🔍
  🔍 11.1               Pass:  71%/7   | Total: 58m 27s | Avg:  8m 21s | Max: 34m 00s | Hits: 356%/1852  
  🟩 12.5               Pass: 100%/2   | Total: 41m 31s | Avg: 20m 45s | Max: 22m 02s
  🟩 12.6               Pass: 100%/37  | Total:  7h 55m | Avg: 12m 51s | Max: 38m 00s | Hits: 356%/7408  
🔍 cudacxx: nvcc11.1 🔍
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 21m 09s | Avg: 10m 34s | Max: 10m 44s
  🔍 nvcc11.1           Pass:  71%/7   | Total: 58m 27s | Avg:  8m 21s | Max: 34m 00s | Hits: 356%/1852  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 41m 31s | Avg: 20m 45s | Max: 22m 02s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  7h 34m | Avg: 12m 59s | Max: 38m 00s | Hits: 356%/7408  
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/2   | Total: 21m 09s | Avg: 10m 34s | Max: 10m 44s
  🔍 nvcc               Pass:  95%/44  | Total:  9h 14m | Avg: 12m 36s | Max: 38m 00s | Hits: 356%/9260  
🔍 cxx_family: GCC 🔍
  🟩 Clang              Pass: 100%/19  | Total:  2h 59m | Avg:  9m 25s | Max: 12m 37s
  🔍 GCC                Pass:  89%/19  | Total:  2h 44m | Avg:  8m 40s | Max: 14m 07s
  🟩 Intel              Pass: 100%/1   | Total: 13m 53s | Avg: 13m 53s | Max: 13m 53s
  🟩 MSVC               Pass: 100%/5   | Total:  2h 56m | Avg: 35m 15s | Max: 38m 00s | Hits: 356%/9260  
  🟩 NVHPC              Pass: 100%/2   | Total: 41m 31s | Avg: 20m 45s | Max: 22m 02s
🔍 jobs: Build 🔍
  🔍 Build              Pass:  95%/40  | Total:  8h 02m | Avg: 12m 04s | Max: 36m 14s | Hits: 353%/7408  
  🟩 TestCPU            Pass: 100%/3   | Total: 53m 46s | Avg: 17m 55s | Max: 38m 00s | Hits: 365%/1852  
  🟩 TestGPU            Pass: 100%/3   | Total: 39m 10s | Avg: 13m 03s | Max: 14m 07s
🟨 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 28m 32s | Avg:  7m 08s | Max: 10m 05s
  🟩 Clang10            Pass: 100%/1   | Total: 10m 49s | Avg: 10m 49s | Max: 10m 49s
  🟩 Clang11            Pass: 100%/1   | Total:  9m 10s | Avg:  9m 10s | Max:  9m 10s
  🟩 Clang12            Pass: 100%/1   | Total:  9m 56s | Avg:  9m 56s | Max:  9m 56s
  🟩 Clang13            Pass: 100%/1   | Total:  9m 50s | Avg:  9m 50s | Max:  9m 50s
  🟩 Clang14            Pass: 100%/1   | Total: 10m 13s | Avg: 10m 13s | Max: 10m 13s
  🟩 Clang15            Pass: 100%/1   | Total:  9m 36s | Avg:  9m 36s | Max:  9m 36s
  🟩 Clang16            Pass: 100%/1   | Total: 10m 29s | Avg: 10m 29s | Max: 10m 29s
  🟩 Clang17            Pass: 100%/1   | Total:  9m 39s | Avg:  9m 39s | Max:  9m 39s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 10m | Avg: 10m 08s | Max: 12m 37s
  🟨 GCC6               Pass:  50%/2   | Total:  5m 48s | Avg:  2m 54s | Max:  4m 02s
  🟩 GCC7               Pass: 100%/2   | Total: 14m 32s | Avg:  7m 16s | Max:  9m 59s
  🟩 GCC8               Pass: 100%/1   | Total: 10m 03s | Avg: 10m 03s | Max: 10m 03s
  🟨 GCC9               Pass:  66%/3   | Total: 17m 17s | Avg:  5m 45s | Max: 11m 46s
  🟩 GCC10              Pass: 100%/1   | Total: 10m 48s | Avg: 10m 48s | Max: 10m 48s
  🟩 GCC11              Pass: 100%/1   | Total: 11m 43s | Avg: 11m 43s | Max: 11m 43s
  🟩 GCC12              Pass: 100%/1   | Total: 10m 35s | Avg: 10m 35s | Max: 10m 35s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 23m | Avg: 10m 29s | Max: 14m 07s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 13m 53s | Avg: 13m 53s | Max: 13m 53s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 34m 00s | Avg: 34m 00s | Max: 34m 00s | Hits: 356%/1852  
  🟩 MSVC14.29          Pass: 100%/1   | Total: 33m 44s | Avg: 33m 44s | Max: 33m 44s | Hits: 353%/1852  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  1h 48m | Avg: 36m 11s | Max: 38m 00s | Hits: 357%/5556  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 41m 31s | Avg: 20m 45s | Max: 22m 02s
🟨 std
  🟩 11                 Pass: 100%/5   | Total: 21m 27s | Avg:  4m 17s | Max:  5m 19s
  🟨 14                 Pass:  75%/4   | Total: 55m 50s | Avg: 13m 57s | Max: 34m 00s | Hits: 356%/1852  
  🟨 17                 Pass:  91%/12  | Total:  3h 00m | Avg: 15m 02s | Max: 34m 20s | Hits: 353%/3704  
  🟩 20                 Pass: 100%/23  | Total:  4h 55m | Avg: 12m 49s | Max: 38m 00s | Hits: 359%/3704  
🟨 gpu
  🟨 v100               Pass:  95%/46  | Total:  9h 35m | Avg: 12m 30s | Max: 38m 00s | Hits: 356%/9260  
🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 22m 54s | Avg: 11m 27s | Max: 14m 07s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  7m 08s | Avg:  7m 08s | Max:  7m 08s

  • 🟩 cub: Pass: 100%/47 | Total: 8h 34m | Avg: 10m 57s | Max: 48m 18s | Hits: 599%/3132 

    🟩 cpu
  🟩 amd64              Pass: 100%/45  | Total:  8h 25m | Avg: 11m 13s | Max: 48m 18s | Hits: 599%/3132  
  🟩 arm64              Pass: 100%/2   | Total:  9m 37s | Avg:  4m 48s | Max:  4m 53s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  1h 49m | Avg: 15m 36s | Max: 48m 18s | Hits: 599%/783   
  🟩 12.5               Pass: 100%/2   | Total: 18m 49s | Avg:  9m 24s | Max:  9m 32s
  🟩 12.6               Pass: 100%/38  | Total:  6h 26m | Avg: 10m 10s | Max: 32m 22s | Hits: 599%/2349  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  8m 58s | Avg:  4m 29s | Max:  4m 30s
  🟩 nvcc11.1           Pass: 100%/7   | Total:  1h 49m | Avg: 15m 36s | Max: 48m 18s | Hits: 599%/783   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 18m 49s | Avg:  9m 24s | Max:  9m 32s
  🟩 nvcc12.6           Pass: 100%/36  | Total:  6h 17m | Avg: 10m 29s | Max: 32m 22s | Hits: 599%/2349  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  8m 58s | Avg:  4m 29s | Max:  4m 30s
  🟩 nvcc               Pass: 100%/45  | Total:  8h 25m | Avg: 11m 14s | Max: 48m 18s | Hits: 599%/3132  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 21m 14s | Avg:  5m 18s | Max:  6m 19s
  🟩 Clang10            Pass: 100%/1   | Total:  6m 14s | Avg:  6m 14s | Max:  6m 14s
  🟩 Clang11            Pass: 100%/1   | Total:  5m 34s | Avg:  5m 34s | Max:  5m 34s
  🟩 Clang12            Pass: 100%/1   | Total:  5m 27s | Avg:  5m 27s | Max:  5m 27s
  🟩 Clang13            Pass: 100%/1   | Total:  5m 43s | Avg:  5m 43s | Max:  5m 43s
  🟩 Clang14            Pass: 100%/1   | Total:  5m 42s | Avg:  5m 42s | Max:  5m 42s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 53s | Avg:  5m 53s | Max:  5m 53s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 44s | Avg:  5m 44s | Max:  5m 44s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 41s | Avg:  5m 41s | Max:  5m 41s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 01m | Avg:  8m 44s | Max: 19m 15s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 27s | Avg:  4m 13s | Max:  4m 25s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 20s | Avg:  5m 10s | Max:  5m 13s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 38s | Avg:  5m 38s | Max:  5m 38s
  🟩 GCC9               Pass: 100%/3   | Total: 58m 25s | Avg: 19m 28s | Max: 48m 18s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 17s | Avg:  5m 17s | Max:  5m 17s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 19s | Avg:  5m 19s | Max:  5m 19s
  🟩 GCC12              Pass: 100%/3   | Total: 26m 04s | Avg:  8m 41s | Max: 16m 35s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 55m | Avg: 14m 26s | Max: 32m 22s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total:  6m 24s | Avg:  6m 24s | Max:  6m 24s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 39m 14s | Avg: 39m 14s | Max: 39m 14s | Hits: 599%/783   
  🟩 MSVC14.29          Pass: 100%/1   | Total: 27m 43s | Avg: 27m 43s | Max: 27m 43s | Hits: 599%/783   
  🟩 MSVC14.39          Pass: 100%/2   | Total: 59m 07s | Avg: 29m 33s | Max: 30m 18s | Hits: 599%/1566  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 18m 49s | Avg:  9m 24s | Max:  9m 32s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  2h 08m | Avg:  6m 45s | Max: 19m 15s
  🟩 GCC                Pass: 100%/21  | Total:  3h 55m | Avg: 11m 11s | Max: 48m 18s
  🟩 Intel              Pass: 100%/1   | Total:  6m 24s | Avg:  6m 24s | Max:  6m 24s
  🟩 MSVC               Pass: 100%/4   | Total:  2h 06m | Avg: 31m 31s | Max: 39m 14s | Hits: 599%/3132  
  🟩 NVHPC              Pass: 100%/2   | Total: 18m 49s | Avg:  9m 24s | Max:  9m 32s
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 20m 44s | Avg: 10m 22s | Max: 16m 35s
  🟩 v100               Pass: 100%/45  | Total:  8h 13m | Avg: 10m 58s | Max: 48m 18s | Hits: 599%/3132  
🟩 jobs
  🟩 Build              Pass: 100%/40  | Total:  6h 06m | Avg:  9m 09s | Max: 48m 18s | Hits: 599%/3132  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 22m 50s | Avg: 22m 50s | Max: 22m 50s
  🟩 GraphCapture       Pass: 100%/1   | Total: 17m 20s | Avg: 17m 20s | Max: 17m 20s
  🟩 HostLaunch         Pass: 100%/3   | Total: 56m 27s | Avg: 18m 49s | Max: 22m 05s
  🟩 TestGPU            Pass: 100%/2   | Total: 51m 37s | Avg: 25m 48s | Max: 32m 22s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 20m 44s | Avg: 10m 22s | Max: 16m 35s
  🟩 90a                Pass: 100%/1   | Total:  4m 16s | Avg:  4m 16s | Max:  4m 16s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 24m 11s | Avg:  4m 50s | Max:  6m 19s
  🟩 14                 Pass: 100%/4   | Total: 54m 46s | Avg: 13m 41s | Max: 39m 14s | Hits: 599%/783   
  🟩 17                 Pass: 100%/12  | Total:  2h 38m | Avg: 13m 11s | Max: 48m 18s | Hits: 599%/1566  
  🟩 20                 Pass: 100%/26  | Total:  4h 37m | Avg: 10m 40s | Max: 32m 22s | Hits: 599%/783

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 37s | Avg: 5m 18s | Max: 8m 47s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  8m 47s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  1m 50s | Avg:  1m 50s | Max:  1m 50s
  🟩 Test               Pass: 100%/1   | Total:  8m 47s | Avg:  8m 47s | Max:  8m 47s

  • 🟩 python: Pass: 100%/1 | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 96)
# Runner
71 linux-amd64-cpu16
11 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16
4 linux-arm64-cpu16
1 linux-amd64-gpu-h100-latest-1-testing

miscco
miscco reviewed Jan 15, 2025
View reviewed changes
thrust/testing/async_copy.cu
Comment on lines +13 to +14
_CCCL_SUPPRESS_DEPRECATED_PUSH

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the _CCCL_SUPRESS_DEPRECATEED_POP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco left review comments

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-thrust-codeowners

@gonidelis gonidelis Awaiting requested review from gonidelis gonidelis is a code owner automatically assigned from NVIDIA/cccl-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @miscco