Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Docker login action #8

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Use the Docker login action #8

merged 1 commit into from
Feb 1, 2024

Conversation

mikemckiernan
Copy link
Member

No description provided.

Signed-off-by: Mike McKiernan <[email protected]>
@mikemckiernan mikemckiernan self-assigned this Feb 1, 2024
@mikemckiernan mikemckiernan added the documentation Issue/PR focused on fixing/editing/adding documentation bits label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-8

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -70,7 +75,7 @@ jobs:
with:
fetch-depth: 1
- name: Log in to Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not critical, but we may want to configure dependabot on this repo to automate updates such as these.

@ArangoGutierrez ArangoGutierrez merged commit 0b167d7 into main Feb 1, 2024
5 checks passed
@ArangoGutierrez ArangoGutierrez deleted the chore-docker-login branch February 1, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue/PR focused on fixing/editing/adding documentation bits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants