Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Agent/Environment with runner #332

Closed
Closed
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
d9e854a
Fix ABC usage issues
amaslenn Dec 19, 2024
34cda1f
Add test hooks to USER_GUIDE.md (#322)
TaekyungHeo Jan 6, 2025
0cfd5e6
remove the default condition check
srivatsankrishnan Jan 8, 2025
baa2925
preserves lists in cmd_args as is (for pydantic validation)
srivatsankrishnan Jan 8, 2025
1a26f7f
propate cmd_args type to all places in cloudAI for pyright errors
srivatsankrishnan Jan 8, 2025
aa8a38c
Add ClassVar to remove pydantic annonation error
srivatsankrishnan Jan 8, 2025
c95fefa
fix pytest
srivatsankrishnan Jan 8, 2025
cd8fbbf
Do not check image accessibility using "local" enroot
amaslenn Jan 6, 2025
3f358ea
Do not require enroot binary on head node
amaslenn Jan 6, 2025
41694b7
Pass SlurmSystem into DockerImageCacheManager
amaslenn Jan 6, 2025
1bcb661
Specify account while caching images
amaslenn Jan 6, 2025
2fb9b92
Reduce noise in CLI output
amaslenn Jan 6, 2025
a1ed291
Make ruff happy
amaslenn Jan 6, 2025
f85961b
more unit tests for parser with Grok Test definition + pydantic of on…
srivatsankrishnan Jan 8, 2025
aa2d0d9
ruffing
srivatsankrishnan Jan 8, 2025
3e0864d
Add more test to have ranges for FDL flags.
srivatsankrishnan Jan 8, 2025
e2fe3aa
More test for XLA flags as list other fixed + fixing typing in Grok/J…
srivatsankrishnan Jan 8, 2025
8367cb7
All static values (benchmarking scenarios in CloudAI)
srivatsankrishnan Jan 8, 2025
a7b1633
negative tests with various types in the list
srivatsankrishnan Jan 8, 2025
695a5d0
remove the unit tests
srivatsankrishnan Jan 8, 2025
44a9fda
remove instance check (assuming model_dump() never fails)
srivatsankrishnan Jan 8, 2025
6124236
fix the typing for slurm_args
srivatsankrishnan Jan 8, 2025
f229433
removing the old _parser_cmd method that is not used.
srivatsankrishnan Jan 8, 2025
fd83f65
test and test scenario for environment configuration
srivatsankrishnan Jan 9, 2025
118638a
Add configurable gym environment from test run object
srivatsankrishnan Jan 9, 2025
532c9ad
Configurable cloudaigym environment and tests
srivatsankrishnan Jan 9, 2025
db516e3
reorg the environment under _core directory
srivatsankrishnan Jan 10, 2025
6bfe9e2
fix pyright and pytest issues
srivatsankrishnan Jan 10, 2025
4fc907e
Remove conf/common/test/chakra_replay.toml (#328)
TaekyungHeo Jan 9, 2025
c0f8f6c
checkpoint policy serializer for list/ranges
srivatsankrishnan Jan 10, 2025
dae998f
Add farma gym to requirements
srivatsankrishnan Jan 10, 2025
6487344
vulture check
srivatsankrishnan Jan 10, 2025
cdfb826
fix pyproject.toml
srivatsankrishnan Jan 10, 2025
76f1f2f
Fix the test package errors
srivatsankrishnan Jan 10, 2025
897c4b9
taplo
srivatsankrishnan Jan 10, 2025
bcd45da
port agent interface and grid search
srivatsankrishnan Jan 10, 2025
d31412c
Ignore vulture for grid search
srivatsankrishnan Jan 10, 2025
3ad97cd
vulture and ruff fixes
srivatsankrishnan Jan 10, 2025
bf6c96a
remove comments
srivatsankrishnan Jan 10, 2025
7e10b22
removed the fixed value
srivatsankrishnan Jan 10, 2025
dff5c64
Merge branch 'main' into config-agent
srivatsankrishnan Jan 10, 2025
275bf39
remove the setter
srivatsankrishnan Jan 11, 2025
63efa41
Not introduce range as of now. Stick to static lists
srivatsankrishnan Jan 11, 2025
d945201
agent environment intergation with runner
srivatsankrishnan Jan 11, 2025
1be4398
more fixes
srivatsankrishnan Jan 11, 2025
4df4ab9
Remove Farma gym dependies for more control over types + other fixes …
srivatsankrishnan Jan 11, 2025
e6905f7
vulture fix
srivatsankrishnan Jan 11, 2025
177694f
remove farma gym dependencies + update the pytest for cloudai_gym
srivatsankrishnan Jan 11, 2025
b10dbfb
remove farma gym from pyproject
srivatsankrishnan Jan 11, 2025
15be693
fix the copyright headers checks
srivatsankrishnan Jan 11, 2025
d5d1e14
use iterators to avoid indexing errors.
srivatsankrishnan Jan 11, 2025
96ab055
helper method for manipulating the TestRun object directly
srivatsankrishnan Jan 11, 2025
aa9dcea
Merge branch 'main' into agent-env-integration
srivatsankrishnan Jan 13, 2025
e6f833c
Removing the agent's configuration and instead query from the environ…
srivatsankrishnan Jan 14, 2025
e211b30
Merge branch 'main' into agent-env-integration
srivatsankrishnan Jan 14, 2025
d9b77e5
Merge branch 'agent-env-integration' of https://github.com/srivatsank…
srivatsankrishnan Jan 14, 2025
24fe925
Fix the testing code
srivatsankrishnan Jan 14, 2025
5eb42d0
fix the configurator structure
srivatsankrishnan Jan 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
vulture and ruff fixes
srivatsankrishnan committed Jan 10, 2025

Unverified

This user has not yet uploaded their public signing key.
commit 3ad97cdc43d4dc993d579a92858edf87aa1d68fa
2 changes: 1 addition & 1 deletion src/cloudai/_core/configurator/agents/base_agent.py
Original file line number Diff line number Diff line change
@@ -94,7 +94,7 @@ def select_action(self) -> Dict[str, Any]:
pass

@abstractmethod
def update_policy(self, feedback: Dict[str, Any]) -> None: # noqa: F841
def update_policy(self, _feedback: Dict[str, Any]) -> None:
"""
Update the agent state based on feedback from the environment.

2 changes: 1 addition & 1 deletion src/cloudai/_core/configurator/agents/grid_search.py
Original file line number Diff line number Diff line change
@@ -88,7 +88,7 @@ def select_action(self) -> Dict[str, Any]:
self.index += 1
return action

def update_policy(self, feedback: Dict[str, Any]) -> None: # noqa: F841
def update_policy(self, _feedback: Dict[str, Any]) -> None:
"""
Update the agent based on feedback (not used in grid search).