-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results directory for DSE job #333
Draft
srivatsankrishnan
wants to merge
54
commits into
NVIDIA:main
Choose a base branch
from
srivatsankrishnan:fix_dse_output_dir
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Results directory for DSE job #333
srivatsankrishnan
wants to merge
54
commits into
NVIDIA:main
from
srivatsankrishnan:fix_dse_output_dir
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Inherit from ABC if there @abstractmethods 2. Do not make gen_srun_success_check() abstruct, simply return an empty string by default. When needed, this method will be overriden.
Some slurm setups do not allow running enroot from the head node. Let's rely on actual 'enroot import' run via srun and report its real error message to user.
…e of the variables that is list.
…axtookbox definitions
* Remove conf/common/test/chakra_replay.toml * Remove conf/common/test_scenario/chakra_replay.toml
srivatsankrishnan
force-pushed
the
fix_dse_output_dir
branch
from
January 12, 2025 00:04
5b93508
to
0acf43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the concept of
dse_iteration
and having it baked into the how the results are stored for each iteration. For each dse iteration should generate its own iteration_x folder and then the generated batch and srun scripts. There is alreadycurrent_iteration
anditeration
field in the TestRun definition. Need more discussion on this + accordingly update thetest_slurm
unit test.For normal benchmarking job, there is no concept of iterations. Hence we should expect a folder structure like this.
For DSE job, th
Test Plan
CI/CD
Dry-Run
Additional Notes