Mount NCCL_TOPO_FILE in NCCL test #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
force-pushed
the
nccl-topo
branch
from
585c3ef to
d62e22a
Compare
TaekyungHeo
force-pushed
the
nccl-topo
branch
from
d62e22a to
a64671b
Compare
TaekyungHeo
requested review from
amaslenn,
srivatsankrishnan and
srinivas212
srivatsankrishnan
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR to mount NCCL_TOPO_FILE to the container when NCCL_TOPO_FILE is set. Previously, a pair of environment variables was used to set NCCL_TOPO_FILE. However, this approach was unnecessary and confusing. With this PR, NCCL_TOPO_FILE is mounted to the container whenever it is available.
Test Plan
Ran it on a server.