Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate CSV reports in NCCL-tests #34

Merged
merged 2 commits into from
May 24, 2024
Merged

Generate CSV reports in NCCL-tests #34

merged 2 commits into from
May 24, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented May 24, 2024 •
edited
Loading

Summary

  • Added CSVReportTool for generating CSV reports and implemented unit tests for it.
  • Updated NcclTestReportGenerationStrategy to generate CSV reports using the new CSVReportTool alongside existing Bokeh reports.

Test Plan

  1. Added unit tests
  2. Generated reports
$ cloudai ... --mode=generate-report ... 
$ find . -name '*report*'
./Tests.1/0/cloudai_nccl_test_report.csv
./Tests.1/0/cloudai_nccl_test_bokeh_report.html
./Tests.3/0/cloudai_nccl_test_report.csv
./Tests.3/0/cloudai_nccl_test_bokeh_report.html
./Tests.4/0/cloudai_nccl_test_report.csv
./Tests.4/0/cloudai_nccl_test_bokeh_report.html
./Tests.2/0/cloudai_nccl_test_report.csv
./Tests.2/0/cloudai_nccl_test_bokeh_report.html

@TaekyungHeo TaekyungHeo force-pushed the csv-report branch 2 times, most recently from 9ef53fb to 710f1af Compare May 24, 2024 21:09
@srinivas212 srinivas212 merged commit 1e11c49 into NVIDIA:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivas212 srinivas212 srinivas212 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaekyungHeo @srinivas212