Bug fix in job completion checks #340
Merged
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a bug fix for https://redmine.mellanox.com/issues/4248881. @Bohatchuk reported that Chakra replay fails to generate reports when pre-test hooks are enabled. This issue arises from how job completion is checked. Currently, the system checks for specific keywords such as "COMPLETED" in the output of
sacct
. However, when multiple tasks exist within a single job, the output may include a mix of "RUNNING" and "COMPLETED," as shown below:This scenario should be interpreted as the job still running. Otherwise, jobs may be prematurely marked as complete.
Test Plan
After job completion
Before pre-test hook completion
After pre-test hook completion