Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance installation process with detailed error handling and Docker image caching #57

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented May 31, 2024

Summary

  • Introduced detailed error messages in the installation process.
  • Added a new DockerImageCacheManager to reduce code duplication and manage Docker image caching.
  • Enabled optional caching of Docker images locally.
  • Passed error messages from the lower levels up to the installer and user.
  • Updated various classes and methods to use the new InstallStatusResult for error handling.
  • Modified requirements.txt to include requests library for handling Docker image checks.
  • Added unit tests for the new functionality to ensure reliability and correctness.

Test Plan

Added unit tests.

@TaekyungHeo TaekyungHeo force-pushed the install-better branch 17 times, most recently from 97ea8fe to 9a05218 Compare June 4, 2024 13:24
@TaekyungHeo TaekyungHeo changed the title Add detailed error message on installation Enhance installation process with detailed error handling and Docker image caching Jun 4, 2024
@TaekyungHeo TaekyungHeo marked this pull request as ready for review June 4, 2024 14:09
@amaslenn amaslenn merged commit 967e7d7 into NVIDIA:main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants