Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn cuda-python into a pure Python wheel that depends on the cuda-bindings wheel #356

Merged
merged 14 commits into from
Jan 14, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Jan 6, 2025

Part of #105.

Close #146. Close #167.

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 6, 2025
@leofang leofang self-assigned this Jan 6, 2025
Copy link
Contributor

copy-pr-bot bot commented Jan 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

/ok to test

@leofang leofang added P0 High priority - Must do! CI/CD CI/CD infrastructure packaging Anything related to wheels or Conda packages labels Jan 6, 2025
@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

Challenge: cuda-core needs to depend on either cuda-bindings v11 or 12, but we don't generate the v11 variant in the main branch. We'll need to cache the artifacts from both main and 11.8.x branches so that all pipelines can use them (#329).

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

1 similar comment
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

Turns out the build failure is due to race condition that the upload-artifact did not address with overwrite: true... (search for the 409 error here)

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

The cuda.core + 11.8.0 tests show that a backport of this PR has to be merged first.

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

The cuda.core + 11.8.0 tests show that a backport of this PR has to be merged first.

Review/merge #385 first.

ksimpson-work
ksimpson-work previously approved these changes Jan 13, 2025
@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

FYI I pushed a commit 6bb7c0b to allow passing through [all] to cuda-bindings. It's being backported in #391.

@leofang leofang marked this pull request as ready for review January 14, 2025 00:57
@leofang
Copy link
Member Author

leofang commented Jan 14, 2025

/ok to test

@leofang leofang requested a review from ksimpson-work January 14, 2025 00:58
@leofang
Copy link
Member Author

leofang commented Jan 14, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 14, 2025

The 11.8 CI is green now. Ready for review!

@leofang
Copy link
Member Author

leofang commented Jan 14, 2025

Thanks, Keenan. Let's merge and unblock other PRs. If there's anything needed we can follow up in another PR.

@leofang leofang merged commit fa9b275 into NVIDIA:main Jan 14, 2025
78 checks passed
@leofang leofang deleted the components branch January 14, 2025 14:47
Copy link

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a slim pyproject.toml for cuda-python Publish standalone cuda-bindings packages
2 participants