-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor CI improvements #393
Open
leofang
wants to merge
4
commits into
NVIDIA:main
Choose a base branch
from
leofang:cut_ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
enhancement
Any code-related improvements
P1
Medium priority - Should do
CI/CD
CI/CD infrastructure
labels
Jan 14, 2025
/ok to test |
/ok to test |
/ok to test |
leofang
commented
Jan 15, 2025
Comment on lines
+233
to
+235
# To test this combo would require nontrivial installation steps. | ||
- cuda-version: "12.0.1" | ||
local-ctk: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes the 10 redundant jobs
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuda.bindings
in parallel might fail non-deterministically #271 was fixed; now that it can be guaranteed, let's enforce it to avoid waiting in the self-runner queue while some builds still fail (due to network connection issues)cuda.bindings
in parallel might fail non-deterministically #271 allows thisfactor out thegh
installation stepthis meansgh
is installed unconditionally instead of as needed, but it is small & quick so I don't worry too much