Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlet velocity and density parameterization in domino #760

Merged
merged 11 commits into from
Jan 21, 2025

Conversation

RishikeshRanade
Copy link
Collaborator

@RishikeshRanade RishikeshRanade commented Jan 14, 2025

Modulus Pull Request

Description

Adding an option for inlet velocity and density parameterization in the domino model.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Sorry, something went wrong.

@RishikeshRanade RishikeshRanade self-assigned this Jan 14, 2025
Copy link
Collaborator

@mnabian mnabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnabian
Copy link
Collaborator

mnabian commented Jan 14, 2025

/blossom-ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mnabian
Copy link
Collaborator

mnabian commented Jan 14, 2025

/blossom-ci

@RishikeshRanade
Copy link
Collaborator Author

/blossom-ci

2 similar comments
@mnabian
Copy link
Collaborator

mnabian commented Jan 15, 2025

/blossom-ci

@RishikeshRanade
Copy link
Collaborator Author

/blossom-ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@RishikeshRanade
Copy link
Collaborator Author

/blossom-ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mnabian
Copy link
Collaborator

mnabian commented Jan 17, 2025

/blossom-ci

@RishikeshRanade
Copy link
Collaborator Author

/blossom-ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@NickGeneva
Copy link
Collaborator

/blossom-ci

1 similar comment
@mnabian
Copy link
Collaborator

mnabian commented Jan 21, 2025

/blossom-ci

@mnabian mnabian merged commit 90c8f68 into NVIDIA:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants