fix bug: enable if_modified_files check for all shims in github actions [skip ci] #11910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
YanxuanLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
Signed-off-by: Yanxuan Liu <[email protected]>
mythrocks
reviewed
Jan 3, 2025
| @@ -62,7 +62,7 @@ | |||
| <executions> | |||
| <execution> | |||
| <id>if_modified_files</id> | |||
| <phase>verify</phase> | |||
| <phase>package</phase> | |||
There was a problem hiding this comment.
Ah, ok. if_modified_files is checked in the package phase instead of verify.
pxLi
changed the title
pxLi
changed the title
pxLi
added
bug
|
Thanks for including the link to the test for this change. |
pxLi
approved these changes
Jan 3, 2025
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11896
Previous only verify stages in github action would help catch the issue to try to remind developers to add docs, but seems people may take it as only need to update the selected failed 4 shims. We updated to add check in package phase to avoid this situation.
test run: https://github.com/YanxuanLiu/spark-rapids/actions/runs/12592479459/job/35097201881?pr=17