Ensure Java Compatibility Check for Regex Patterns #11912
+30
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Aralihalli <[email protected]>
|
build |
Signed-off-by: Suraj Aralihalli <[email protected]>
NVnavkumar
reviewed
Jan 6, 2025
| @@ -51,6 +53,8 @@ class GpuRegExpReplaceMeta( | |||
| expr.regexp match { | |||
| case Literal(s: UTF8String, DataTypes.StringType) if s != null => | |||
| javaPattern = Some(s.toString()) | |||
| // check that this is valid in Java | |||
| Pattern.compile(javaPattern.toString) | |||
There was a problem hiding this comment.
I think we should move this to the RegexTranspiler code. I think it could be done in both getTranspiledAST(...)/RegexParser(...)
Otherwise this line will have to be called in every Regexp Expression class, and it could easily be lost in a few places. The transpiler is used by all of these methods, so this makes sense as a shortcut.
|
the failing spark400 check should succeed now if you rerun it per apache/spark@3ecb290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11651
Before passing the regex pattern to
CudfRegexTranspilerand validating its compatibility with cuDF, we need to first ensure that the pattern is Java-compatiblejava.util.regex.Pattern.compile(pattern). If the pattern is not valid in Java, the same error should be raised for both CPU and GPU runs.