-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jlowe as committer since he retired #11960
Conversation
Signed-off-by: Thomas Graves <[email protected]>
build |
Signed-off-by: Thomas Graves <[email protected]>
build |
<name>Jason Lowe</name> | ||
<email>[email protected]</email> | ||
<roles> | ||
<role>Committer</role> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my understanding of https://maven.apache.org/xsd/maven-4.0.0.xsd the text within <role>
can be chosen arbitrarily. So instead of dropping the entry entirely we could say Emeritus Committer
Email can be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't matter to me to much, its really more of a project process type thing. Are there any benefits to it over removing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it more graceful to continue giving credit for significant contributions and many projects seem to have an Emeritus status. On the other hand, I am not familiar with projects maintaining the list of committers in a pom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything for contributions is in git history. I don't see putting him as emeritus in the pom file for list of committers as being a big deal personally. There are no plans for him to come back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this, if someone has a strong feeling we can revert and put him back in as Emeritus
Remove user jlowe from the pom as a committer and being allowed to kick the builds.