Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jlowe as committer since he retired #11960

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

tgravescs
Copy link
Collaborator

@tgravescs tgravescs commented Jan 13, 2025

Remove user jlowe from the pom as a committer and being allowed to kick the builds.

@tgravescs tgravescs self-assigned this Jan 13, 2025
@tgravescs tgravescs requested a review from a team as a code owner January 13, 2025 18:58
@tgravescs
Copy link
Collaborator Author

build

@tgravescs
Copy link
Collaborator Author

build

<name>Jason Lowe</name>
<email>[email protected]</email>
<roles>
<role>Committer</role>
Copy link
Collaborator

@gerashegalov gerashegalov Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my understanding of https://maven.apache.org/xsd/maven-4.0.0.xsd the text within <role> can be chosen arbitrarily. So instead of dropping the entry entirely we could say Emeritus Committer

Email can be omitted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't matter to me to much, its really more of a project process type thing. Are there any benefits to it over removing?

Copy link
Collaborator

@gerashegalov gerashegalov Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it more graceful to continue giving credit for significant contributions and many projects seem to have an Emeritus status. On the other hand, I am not familiar with projects maintaining the list of committers in a pom

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything for contributions is in git history. I don't see putting him as emeritus in the pom file for list of committers as being a big deal personally. There are no plans for him to come back.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this, if someone has a strong feeling we can revert and put him back in as Emeritus

@sameerz sameerz added the build Related to CI / CD or cleanly building label Jan 13, 2025
@tgravescs tgravescs merged commit c3029d8 into NVIDIA:branch-25.02 Jan 14, 2025
50 checks passed
@tgravescs tgravescs deleted the removejlowe2 branch January 14, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants