Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xtransformer to backend #798
base: main
Are you sure you want to change the base?
Add Xtransformer to backend #798
Changes from 17 commits
fb13401
e249715
5cc207b
5a18d98
6129965
02ff772
3d06ebe
8555bab
c11ba38
4a82ea2
367e493
aa96ebc
efbb05c
3731f47
6187e91
3e02a72
7379061
2078a65
f1b9c78
5e41dce
4c33a31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 96 in annif/backend/__init__.py
Codecov / codecov/patch
annif/backend/__init__.py#L96
Check warning on line 13 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L11-L13
Check warning on line 17 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L15-L17
Check warning on line 24 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L24
Check warning on line 28 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L28
Check warning on line 30 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L30
Check warning on line 32 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L32
Check warning on line 34 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L34
Check warning on line 38 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L37-L38
Check warning on line 40 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L40
Check warning on line 45 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L42-L45
Check warning on line 47 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding my previous comments about hyperparamters: it should be fairly easy to incorporate additonal hyperparameters:
Adding the following lines to
PARAM_CONFIG
would allow us to make use of the hyperparamtersCp
andCn
in the project configurations:And similarly for the dict
DEFAULT_PARAMETERS
:Let me know if there are any questions!
Check warning on line 85 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L85
Check warning on line 128 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L123-L128
Check warning on line 130 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L130
Check warning on line 136 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L134-L136
Check warning on line 141 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L138-L141
Check warning on line 155 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L143-L155
Check warning on line 165 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L165
Check warning on line 171 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L171
Check warning on line 179 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L178-L179
Check warning on line 189 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L184-L189
Check warning on line 192 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L192
Check warning on line 196 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L196
Check warning on line 202 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L198-L202
Check warning on line 212 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L212
Check warning on line 214 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L214
Check warning on line 221 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L220-L221
Check warning on line 226 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L223-L226
Check warning on line 233 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L231-L233
Check warning on line 235 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L235
Check warning on line 238 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L238
Check warning on line 243 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L240-L243
Check warning on line 259 in annif/backend/xtransformer.py
Codecov / codecov/patch
annif/backend/xtransformer.py#L251-L259