Disallow f264 duplication: only first entry of dc.title.alternative g…

…enerates the field
NatLibFi · Nov 4, 2024 · 146089f · 146089f
1 parent 746584f
commit 146089f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/src/transform/convert/common/generate2xx.js b/src/transform/convert/common/generate2xx.js
@@ -33,10 +33,12 @@ export function generate245({getFields, getFieldValues}) {
  */
 export function generate246({getFieldValues}) {
   const values = getFieldValues('dc.title.alternative');
-  return values.map(value => ({
-    tag: '246', ind1: '1', ind2: '3',
-    subfields: [{code: 'a', value}]
-  }));
+  return values.length > 0 ? [
+    {
+      tag: '246', ind1: '1', ind2: '3',
+      subfields: [{code: 'a', value: values[0]}]
+    }
+  ] : [];
 }
 
 /**

diff --git a/test-fixtures/transform/convert/common/generate2xx/generate246/01/metadata.json b/test-fixtures/transform/convert/common/generate2xx/generate246/01/metadata.json
@@ -1,4 +1,4 @@
 {
-  "description": "Generates a f246 from each dc.title.alternative information.",
+  "description": "Generates a f246 from first dc.title.alternative information.",
   "only": false
 }
diff --git a/test-fixtures/transform/convert/common/generate2xx/generate246/01/output.json b/test-fixtures/transform/convert/common/generate2xx/generate246/01/output.json
@@ -4,11 +4,5 @@
     "subfields": [
       {"code": "a", "value": "Dublin Core - MARC21 -conversion"}
     ]
-  },
-  {
-    "tag": "246", "ind1": "1", "ind2": "3",
-    "subfields": [
-      {"code": "a", "value": "Och samma på svenska"}
-    ]
   }
 ]