-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First steps in adding Silicon Labs CIP-51 to the 8051 language files #7320
Open
gtackett
wants to merge
13
commits into
NationalSecurityAgency:master
Choose a base branch
from
gtackett:language_files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+528
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h addrress space and extend SFR address space to two byte. Conditionalized definition of SFR space so that CIP51 gets 2 bytes (Intel MCS51 uses 1 byte) and add IFLASH address space to CIP51.
Retains for now the 8051 "default" compiler, adding a "stub" (that is, commented-out) compiler definition for Keil Cx51 and commenting out (preparatory to eventually deleting) the line for the Archimedes compiler that Keil bought out and obsoleted.
…nto language_files
ryanmkurtz
added
Status: Prioritize
This is currently being prioritized
Feature: Processor/8051
labels
Jan 5, 2025
For CIP-51 follow convention of lower-case filenames While I was at it, normalized indentation of "manualindexfile" items.
Abide by lowercase filename convention. Make the slafile name match the name of this variant. Make this version 1.0 of the cip-51 language.
Removed SFRs not in CIP-51, renamed several holdovers from 8051, added comment annotations to SFRs on Page 0 and on All Pages.
Still need to compare to what I have at home
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8051.ldefs
, and for this variant specifically:cx51.cspec
is complete8051_main.sinc
added internal flash address space and expanded SFR address space, both conditionalized on CIP51,cx51.cspec
towards implementing Keil's Cx51 calling convention.