Fix for #53 (debug switch not passed to getVTInfo) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggested fix for #53, which prevents debug messages from displaying during the
getVTInfofunction. As noted in the issue, the while loop ingetVTInfois prone to silent failure and endless looping (#29) and the lack of debug info even when the--debugswitch is applied makes it look like everything is fine if you're not familiar with the program's normal output.The fix is simply to supply the
args.debugvalue to thegetVTInfofunction, as appears to be standard elsewhere in the application.