add blob price update fraction #8053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishqjasoria
changed the title
tanishqjasoria
force-pushed
the
blob-price-fractiion
branch
from
1580311 to
1286aea
Compare
tanishqjasoria
commented
Jan 15, 2025
| @@ -149,6 +149,6 @@ public void Test_StoreBeaconRoot_AccessListNotNull() | |||
|
|
|||
| transaction.Hash = transaction.CalculateHash(); | |||
| _transactionProcessor.Received().Execute(Arg.Is<Transaction>(t => | |||
| t.Hash == transaction.Hash), header, NullTxTracer.Instance); | |||
| t.Hash == transaction.Hash), new BlockExecutionContext(header, 0), NullTxTracer.Instance); | |||
There was a problem hiding this comment.
this is assuming that system transaction will not have blobs, so 0 blobBaseFee will not be a issues.
tanishqjasoria
commented
Jan 15, 2025
| else | ||
| { | ||
| spec.BlobBaseFeeUpdateFraction = blobCount.BaseFeeUpdateFraction; | ||
| } |
There was a problem hiding this comment.
this is a temp things, untill this gets merged
| @@ -12,12 +13,12 @@ public readonly struct BlockExecutionContext | |||
| public BlockHeader Header { get; } | |||
| public UInt256? BlobBaseFee { get; } | |||
|
|
|||
| public BlockExecutionContext(BlockHeader blockHeader) | |||
| public BlockExecutionContext(BlockHeader blockHeader, IReleaseSpec spec) | |||
There was a problem hiding this comment.
Refactor idea:
Maybe we should save the whole spec and reuse it later, while removing SpecProvider dependency and manually getting spec in lot of places in VM or TransactionProcessor?
There was a problem hiding this comment.
sounds like a good idea, i will explore this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.