TiffIO: Allow bottom left origin for images #1428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meeting discussion: string parsing vs boolean for setting bottom-left vs top-left. |
zm711
commented
Apr 13, 2024
|
@apdavison I think you're best to review this, but if you think someone else is better just let me know. This is done now so you can review and merge whenever you want (or at our next meeting--no rush). |
|
@apdavison double check this before 0.14 |
|
@apdavison now that we've fixed the ci this is ready to review before the meeting next week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #876.
I added in a note (in the docstring) explaining that upper left is the python default (from PIL and pillow). As a default I left the upper left, but if the user sets a new argument
python_image_origin=False, then it will do bottom left. I agree that upper left is weird, but it is what the python world expects, so I think the boolean is fair (python standard vs other standard).python_image_originso if someone has a better name let me know.