Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy 2.0 support for IOs #1614

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zm711
Copy link
Contributor

@zm711 zm711 commented Dec 13, 2024

We also need to start seeing which IOs are potentially not 2.0 ready. This is just a draft to start assessing this.

This is much better than I was expecting :)

FAILED neo/test/rawiotest/test_blackrockrawio.py::TestBlackrockRawIO::test_compare_blackrockio_with_matlabloader - KeyError: np.int64(-1)
FAILED neo/test/rawiotest/test_blackrockrawio.py::TestBlackrockRawIO::test_compare_blackrockio_with_matlabloader_v21 - OverflowError: Python integer -1 out of bounds for uint16
FAILED neo/test/rawiotest/test_blackrockrawio.py::TestBlackrockRawIO::test_read_all - KeyError: np.int64(-1)
FAILED neo/test/rawiotest/test_plexonrawio.py::TestPlexonRawIO::test_read_all - OverflowError: Python integer 4294967296 out of bounds for uint16

@zm711 zm711 added the IO label Jan 7, 2025
@zm711
Copy link
Contributor Author

zm711 commented Jan 8, 2025

@samuelgarcia you can see the errors here for blackrock :)

@zm711
Copy link
Contributor Author

zm711 commented Jan 10, 2025

I almost forgot about the med format. The Dark Horse Devs said they would help work on it when ready see issue here. Do we want to ping them for NumPy 2.0 or do we want to just have a branch to test if we want to fix it ourselves. I think they are doing some more major API changes. So maybe we actually want to have a separate install option for users? Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants