-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Only embed specs/namespaces for types that are included in NWB file on export #615
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 95.18% 95.19% +0.01%
==========================================
Files 124 137 +13
Lines 5045 5165 +120
==========================================
+ Hits 4802 4917 +115
- Misses 243 248 +5 ☔ View full report in Codecov by Sentry. |
Update docstring
Add utility function for listing the type hierarchy of an nwb type
…ataWithoutBorders/matnwb into add-nwb-install-extension
Add schedule event for workflow to update nwbInstallExtension
Remove local function
Co-authored-by: Ben Dichter <[email protected]>
…extension_api.rst Co-authored-by: Ben Dichter <[email protected]>
Add example to docstring
Introduce some functions that will be useful later
Add arguments block, fix function name
Redefine listNwbTypes method, add validation of embedded namespaces
@@ -0,0 +1,16 @@ | |||
function deleteGroup(fileReference, groupLocation) | |||
% deleteGroup - Delete the specified group from an NWB file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a big deal that way this is used here, but note that deleting groups and datasets from an HDF5 file does not free up the space
There are lots of new functions here that lack unit tests |
Fix #607
Motivation
Ensure that only relevant namespaces/specifications are embedded in an NWB file. This issue suggests that such extra namespaces can cause errors when validating with NWBInspector.
How to test the behavior?
Questions / todo
kebab-case
? - Appears sosnake_case
? - Appears soShould thespecification
group be completely cleared before rewriting it if exporting to an existing file?Checklist
fix #XX
whereXX
is the issue number?