add link spike_event_series to UnitSeries

[bendichter]

Trying to get links working. Having some trouble. help @ajtritt?

[ajtritt]

the issues here should be fixed by 99281d7

fixed

[codecov]

Codecov Report

Merging #825 into enh/add_UnitSeries will decrease coverage by 0.05%.
The diff coverage is 63.15%.

@@                  Coverage Diff                   @@
##           enh/add_UnitSeries     #825      +/-   ##
======================================================
- Coverage               73.85%   73.79%   -0.06%     
======================================================
  Files                      60       60              
  Lines                    7191     7198       +7     
  Branches                 1514     1517       +3     
======================================================
+ Hits                     5311     5312       +1     
- Misses                   1453     1455       +2     
- Partials                  427      431       +4

Impacted Files	Coverage Δ
src/pynwb/ecephys.py	97.36% <100%> (+0.02%)	⬆️
src/pynwb/form/build/map.py	72.2% <50%> (-0.19%)	⬇️
src/pynwb/form/spec/spec.py	78.7% <60%> (-0.23%)	⬇️
src/pynwb/form/utils.py	88.08% <0%> (-0.3%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfaae4...935c861. Read the comment docs.

[codecov]

Codecov Report

Merging #825 into enh/add_UnitSeries will decrease coverage by 0.05%.
The diff coverage is 63.15%.

@@                  Coverage Diff                   @@
##           enh/add_UnitSeries     #825      +/-   ##
======================================================
- Coverage               73.85%   73.79%   -0.06%     
======================================================
  Files                      60       60              
  Lines                    7191     7198       +7     
  Branches                 1514     1517       +3     
======================================================
+ Hits                     5311     5312       +1     
- Misses                   1453     1455       +2     
- Partials                  427      431       +4

Impacted Files	Coverage Δ
src/pynwb/ecephys.py	97.36% <100%> (+0.02%)	⬆️
src/pynwb/form/build/map.py	72.2% <50%> (-0.19%)	⬇️
src/pynwb/form/spec/spec.py	78.7% <60%> (-0.23%)	⬇️
src/pynwb/form/utils.py	88.08% <0%> (-0.3%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfaae4...935c861. Read the comment docs.

[bendichter]

Oliver wants to talk about this PR on Thursday before we merge

[bendichter]

@oruebel what do you think? Can we merge this in?

[oruebel]

Since this changes the schema, at the very least the version of the schema should then change as well. Since the change is backward compatible with 2.0.0, I guess the version should probably be 2.0.1. We then also need to update the release notes in the nwb-schema repo to document the schema change. I assume this change will also affect MatNWB, i.e., we would need to update it as well. We should create a guideline document for updating the schema, i.e., how changes get reviewed and approved and what steps we need to take to get them in.

[bendichter]

Yes I agree. I have tested these changes with matnwb and they work with the repo as is.

…

On Tue, Mar 12, 2019 at 6:01 PM Oliver Ruebel ***@***.***> wrote: Since this changes the schema, at the very least the version of the schema should then change as well. Since the change is backward compatible with 2.0.0, I guess the version should probably be 2.0.1. We then also need to update the release notes in the nwb-schema repo to document the schema change. I assume this change will also affect MatNWB, i.e., we would need to update it as well. We should create a guideline document for updating the schema, i.e., how changes get reviewed and approved and what steps we need to take to get them in. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#825 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAziEiPW_cep0lDopITJIJlkxdHVzrM2ks5vWCPLgaJpZM4bB-Hu> .

-- ---------- Ben Dichter, PhD Data Science Consultant

[bendichter]

the same goes for #822

[ajtritt]

@bendichter @oruebel Has this PR gone the way of #822?