-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.aiohomekit: init at 0.2.60 #108505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on 3.7 and 3.8, broken on 3.9 due to
error: astroid-2.4.2 not supported for interpreter python3.9
They added tests for 3.9 in pylint-dev/astroid@11ecc08, so here's hoping.+
Anyway, you seem to be missing the component-packages change.
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 2 packages built:
|
Result of 1 package failed to build:
1 package built:
|
sha256 = "03llk5i22hq163x568kz0qar5h0sda8f8cxbmgya6z2dcxv0a83p"; | ||
}; | ||
|
||
nativeBuildInputs = [ poetry ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another case for the poetry-core
dance, you know how it goes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not sure what your issue on python37 was, but I can't seem to be able to make it fail, tried several times.
Motivation for this change
This Python library implements the HomeKit protocol for controlling
Homekit accessories.
https://github.com/Jc2k/aiohomekit
This is a Home Assistant dependency.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)