Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larynx: Init at 1.1.0 (WIP) #174131

Closed
wants to merge 3 commits into from
Closed

Conversation

TilCreator
Copy link
Contributor

@TilCreator TilCreator commented May 23, 2022

Description of changes

Adds Larynx

This PR is very much WIP and does not build jet as it requires onnxruntime with python bindings.

Like any good sciency ml project the repo looks a little cluttered and there are still extra model files to handle.

####### Waiting on

Things done

Add larynx and phonemes2ids

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@TilCreator TilCreator changed the title Package larynx larynx: Init at 1.1.0 (WIP) May 23, 2022
Copy link
Member

@puffnfresh puffnfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the Python parts but the onnxruntime stuff seems pretty much the same as I originally implemented.

@puffnfresh
Copy link
Member

onnxruntime was merged in #186643

@mweinelt
Copy link
Member

And we have larynx2 since #210303. Was much easier to package and is written in C++.

@mweinelt mweinelt closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants