Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: blivet: init at 3.8.1 #260572

Closed
wants to merge 1 commit into from
Closed

WIP: blivet: init at 3.8.1 #260572

wants to merge 1 commit into from

Conversation

jfvillablanca
Copy link
Member

Description of changes

Partially resolves #257955
This builds if tests are disabled.
I am unable to make the upstream tests work

ValueError: Namespace BlockDev not available

Relevant Issue: storaged-project/blivet#894

Can someone help me with the required package here.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 12, 2023
@CyberShadow
Copy link
Contributor

CyberShadow commented Dec 24, 2023 •
edited
Loading

@jfvillablanca I got it working (before I saw your PR), here:

master...CyberShadow:nixpkgs:pull-20231224-104834

I am now stuck at gi.repository.GLib.GError: gtk-icon-theme-error-quark: Icon 'edit-delete-symbolic' not present in theme Adwaita (0) in blivet-gui (fixed that problem now), and this problem makes it difficult to debug.

@CyberShadow
Copy link
Contributor

PR posted: #276662

@jfvillablanca
Copy link
Member Author

@jfvillablanca I got it working (before I saw your PR), here:

master...CyberShadow:nixpkgs:pull-20231224-104834

I am now stuck at gi.repository.GLib.GError: gtk-icon-theme-error-quark: Icon 'edit-delete-symbolic' not present in theme Adwaita (0) in blivet-gui (fixed that problem now), and this problem makes it difficult to debug.

Thanks for working on this. I haven't had the opportunity to revisit this issue. If your PR gets merged, I'll close this PR draft

@CyberShadow CyberShadow mentioned this pull request Dec 25, 2023
Merged
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Blivet-gui
3 participants
@jfvillablanca @CyberShadow @wegank