Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/switch-to-configuration: correctly handle template instances with '.' in name #286202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/switch-to-configuration: correctly handle template instances with '.' in name #286202

wants to merge 2 commits into from

Conversation

jackwilsdon
Copy link
Contributor

@jackwilsdon jackwilsdon commented Feb 4, 2024 •
edited
Loading

Description of changes

This PR changes switch-to-configuration.pl and switch-to-configuration-ng to correctly handle templated service instances containing "." in their name (e.g. [email protected]). Prior to this change, these services were not started, restarted or stopped on configuration change.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jackwilsdon jackwilsdon requested a review from dasJ as a code owner February 4, 2024 02:57
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 4, 2024
@jackwilsdon jackwilsdon force-pushed the fix-instance-name-dot branch from d3a7b5e to 0dfd150 Compare February 12, 2024 16:43
@stigtsp
Copy link
Member

stigtsp commented May 13, 2024

@ofborg test switchTest

@stigtsp stigtsp requested a review from marcusramberg May 13, 2024 16:56
@r-vdp
Copy link
Contributor

r-vdp commented Oct 26, 2024

Could you make the corresponding change in s-t-c-ng?

@stigtsp
Copy link
Member

stigtsp commented Oct 26, 2024

@ofborg test switchTest

@jackwilsdon jackwilsdon force-pushed the fix-instance-name-dot branch from 0dfd150 to b46fde3 Compare October 26, 2024 11:20
@stigtsp
Copy link
Member

stigtsp commented Oct 26, 2024

@ofborg test switchTest

@r-vdp
Copy link
Contributor

r-vdp commented Oct 26, 2024

@ofborg test switchTestNg

stigtsp
stigtsp approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@marcusramberg marcusramberg marcusramberg approved these changes

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackwilsdon @stigtsp @r-vdp @marcusramberg @wegank