-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zwave-js-ui: init at 9.27.8; nixos/zwave-js-ui: init module #336623
base: master
Are you sure you want to change the base?
Conversation
57f5b1f
to
981e638
Compare
981e638
to
55eb391
Compare
55eb391
to
a1c6e2f
Compare
a1c6e2f
to
9324bd9
Compare
Rebased onto latest master due to documentation conflict |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4532 |
9324bd9
to
008b9ef
Compare
@Aleksanaa thanks for the feedback, your suggestions have been implemented |
008b9ef
to
d07b3c4
Compare
d07b3c4
to
ad3b206
Compare
ad3b206
to
b3a2a87
Compare
a1cf688
to
5f94761
Compare
5f94761
to
a47877e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package implementation looks good !
I'm not really confident enough to review the module though.
2019c48
to
f880129
Compare
d0af082
to
ca5811b
Compare
Provides systemd service and allows configuration of data directory
ca5811b
to
d7ba3b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
x86_64-linux test
/nix/store/155jp5nrrsfs7jk1vxzdf1aav4byp0y2-vm-test-run-zwave-js-ui
Description of changes
Resolves #230686
zwave-js-ui is a full featured Z-Wave Control Panel and MQTT Gateway
This PR incorporates both a package and a module to create a service for it if desired
Second package and first module, so let me know if something needs to be changed
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.