Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-wallpaperengine: init at 0-unstable-2024-10-13 #348336

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Oct 13, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 13, 2024
@Noodlez1232
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348336


x86_64-linux

✅ 1 package built:
  • linux-wallpaperengine

@Noodlez1232
Copy link
Contributor

I'm so glad this exists as well. I loved wallpaper engine when I was still using Windows.

@Steinhagen
Copy link
Contributor

This doesn't seem to work for me:

# nix run github:aucub/nixpkgs/linux-wallpaperengine#linux-wallpaperengine
[1021/221813.686260:WARNING:resource_util.cc(94)] Please customize CefSettings.root_cache_path for your application. Use of the default value may lead to unintended process singleton behavior.
Cannot find directory for steam app wallpaper_engine: assets
terminate called after throwing an instance of 'WallpaperEngine::Assets::CAssetLoadException'
  what():  Cannot find file : Cannot find directory
src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

[0100/000000.976815:WARNING:sandbox_linux.cc(400)] InitializeSandbox() called with multiple threads in process gpu-process.
zsh: IOT instruction (core dumped)  nix run github:aucub/nixpkgs/linux-wallpaperengine#linux-wallpaperengine

@g-libardi
Copy link

This doesn't seem to work for me:

# nix run github:aucub/nixpkgs/linux-wallpaperengine#linux-wallpaperengine
[1021/221813.686260:WARNING:resource_util.cc(94)] Please customize CefSettings.root_cache_path for your application. Use of the default value may lead to unintended process singleton behavior.
Cannot find directory for steam app wallpaper_engine: assets
terminate called after throwing an instance of 'WallpaperEngine::Assets::CAssetLoadException'
  what():  Cannot find file : Cannot find directory
src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

[0100/000000.976815:WARNING:sandbox_linux.cc(400)] InitializeSandbox() called with multiple threads in process gpu-process.
zsh: IOT instruction (core dumped)  nix run github:aucub/nixpkgs/linux-wallpaperengine#linux-wallpaperengine

@Steinhagen Actually i do receive this issue too every time i run the pkg, but it works just fine. The problem is that you are just running it without passing any args. Try installing it with nix profile install just like i did and then run it as:
linux-wallpaperengine <workshop_id>

I know this one from frieren works for sure:
https://steamcommunity.com/sharedfiles/filedetails/?id=3135696887
Be sure to subscribe to it

@Steinhagen
Copy link
Contributor

This still doesn't seem to work with: linux-wallpaperengine <workshop_id>

# linux-wallpaperengine 3135696887
[1021/223143.093652:WARNING:resource_util.cc(94)] Please customize CefSettings.root_cache_path for your application. Use of the default value may lead to unintended process singleton behavior.
Cannot find workshop directory for steam app 431960 and content 3135696887
terminate called after throwing an instance of 'std::runtime_error'
  what():  Cannot find workshop directory for steam app 431960 and content 3135696887
src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

[0100/000000.413098:WARNING:sandbox_linux.cc(400)] InitializeSandbox() called with multiple threads in process gpu-process.
zsh: IOT instruction (core dumped)  linux-wallpaperengine 3135696887

@Steinhagen
Copy link
Contributor

This still doesn't seem to work with: linux-wallpaperengine <workshop_id>

# linux-wallpaperengine 3135696887
[1021/223143.093652:WARNING:resource_util.cc(94)] Please customize CefSettings.root_cache_path for your application. Use of the default value may lead to unintended process singleton behavior.
Cannot find workshop directory for steam app 431960 and content 3135696887
terminate called after throwing an instance of 'std::runtime_error'
  what():  Cannot find workshop directory for steam app 431960 and content 3135696887
src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

src/gbm_drv_common.c:131: GBM-DRV error (get_bytes_per_component): Unknown or not supported format: 808530000

[0100/000000.413098:WARNING:sandbox_linux.cc(400)] InitializeSandbox() called with multiple threads in process gpu-process.
zsh: IOT instruction (core dumped)  linux-wallpaperengine 3135696887

Is steam and wallpaper engine installed?

I was under the impression that this is now a standalone app and doesn't rely on steam anymore (I haven't used the app in a few years).
I will correctly setup up wallpaperengine on steam and give this another try. Thanks and sorry for the confusion.

@Steinhagen
Copy link
Contributor

Steinhagen commented Oct 22, 2024

@aucub Maybe it's something that I'm messing up, but do you know why this is failing?

image

P.S.: The app was installed using: nix shell github:aucub/nixpkgs/linux-wallpaperengine#linux-wallpaperengine

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4741

@Steinhagen
Copy link
Contributor

After properly starting the wallpaper engine and subscribing to the desired asset, linux-wallpaperengine <workshop_id> works as expected. This was a problem with the way I was using it.
Other than that, the code looks good and the vulnerability was removed. LGTM.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024
@aucub aucub force-pushed the linux-wallpaperengine branch from 563f07d to 1ca5771 Compare October 26, 2024 11:31
@aucub aucub changed the title linux-wallpaperengine: restore linux-wallpaperengine: init at 0-unstable-2024-10-13 Oct 26, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024
@aucub aucub force-pushed the linux-wallpaperengine branch from 1ca5771 to 87bee8e Compare November 4, 2024 14:38
@aucub aucub requested a review from SuperSandro2000 November 4, 2024 14:45
@aucub aucub force-pushed the linux-wallpaperengine branch from 87bee8e to e2dac78 Compare November 4, 2024 17:08
@SuperSandro2000 SuperSandro2000 merged commit 1eaed9d into NixOS:master Nov 5, 2024
27 of 28 checks passed
@aucub aucub deleted the linux-wallpaperengine branch November 5, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Re-add linux-wallpaperengine
7 participants