-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlPackages.AppSqitch: 1.4.0 -> 1.4.1 #351171
Conversation
@ofborg build perl540Packages.AppSqitch |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the contribution and welcome to the project :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and welcome! 🎉 🚀
Bump sqitch tool from v1.4.0 to v1.4.1
This realease https://github.com/sqitchers/sqitch/releases/tag/v1.4.1 mostly contains bug fixes. Most notably:
which is related to sqitch v1.4.0 failing on some machines due too bug in setting a locale. This was fixed here sqitchers/sqitch#806 (comment) and pushed to v1.4.1.
Other comments from release notes don't look like a breaking change. I have checked note:
And this doesn't seem like a breaking change as
TestWarn
is at version0.37
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/perl-packages.nix#L26217Note: This package doesn't have tests so no automated tests are run
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.