Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: remove left-over rtc_cmos rootModule #359416

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions nixos/lib/make-multi-disk-zfs-image.nix
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,7 @@ let
image = (
pkgs.vmTools.override {
rootModules =
[ "zfs" "9p" "9pnet_virtio" "virtio_pci" "virtio_blk" ] ++
(pkgs.lib.optional pkgs.stdenv.hostPlatform.isx86 "rtc_cmos");
[ "zfs" "9p" "9pnet_virtio" "virtio_pci" "virtio_blk" ];
kernel = modulesTree;
}
).runInLinuxVM (
Expand Down
3 changes: 1 addition & 2 deletions nixos/lib/make-single-disk-zfs-image.nix
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,7 @@ let
image = (
pkgs.vmTools.override {
rootModules =
[ "zfs" "9p" "9pnet_virtio" "virtio_pci" "virtio_blk" ] ++
(pkgs.lib.optional pkgs.stdenv.hostPlatform.isx86 "rtc_cmos");
[ "zfs" "9p" "9pnet_virtio" "virtio_pci" "virtio_blk" ];
kernel = modulesTree;
}
).runInLinuxVM (
Expand Down
3 changes: 0 additions & 3 deletions nixos/modules/system/boot/kernel.nix
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,6 @@ in
] ++ optionals pkgs.stdenv.hostPlatform.isx86 [
# Misc. x86 keyboard stuff.
"pcips2" "atkbd" "i8042"

# x86 RTC needed by the stage 2 init script.
"rtc_cmos"
]);

boot.initrd.kernelModules =
Expand Down
1 change: 0 additions & 1 deletion pkgs/build-support/vm/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
, storeDir ? builtins.storeDir
, rootModules ?
[ "virtio_pci" "virtio_mmio" "virtio_blk" "virtio_balloon" "virtio_rng" "ext4" "unix" "9p" "9pnet_virtio" "crc32c_generic" ]
++ pkgs.lib.optional pkgs.stdenv.hostPlatform.isx86 "rtc_cmos"
}:

let
Expand Down