Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.11] unbound: 1.21.1 -> 1.22.0 with cross fixes #370926

Open
wants to merge 4 commits into
base: staging-24.11
Choose a base branch
from
Open

[24.11] unbound: 1.21.1 -> 1.22.0 with cross fixes #370926

wants to merge 4 commits into from

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Jan 4, 2025 •
edited
Loading

Closes #363704

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex Scrumplex marked this pull request as ready for review January 4, 2025 18:24
@wolfgangwalther wolfgangwalther mentioned this pull request Jan 11, 2025
Closed
1 task
Scrumplex and others added 4 commits January 13, 2025 15:16
@Scrumplex
unbound: 1.21.1 -> 1.22.0
f6cca71 
Signed-off-by: Sefa Eyeoglu <[email protected]>
(cherry picked from commit 0298669)
@Scrumplex
unbound: fetch source from GitHub
7f22717 
To avoid a xz-style supply chain attack.

Signed-off-by: Sefa Eyeoglu <[email protected]>
(cherry picked from commit c011c36)
@FliegendeWurst @Scrumplex
unbound: support dynlib module (NixOS#333301)
1efeefe 
(cherry picked from commit eafaee7)
@misuzu @Scrumplex
unbound: bison is required when cross-compiling
bb8689c 
(cherry picked from commit 6e40f85)
@Scrumplex Scrumplex force-pushed the 24.11/pkgs/unbound/backports branch from 98a9c0b to bb8689c Compare January 13, 2025 14:16
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 13, 2025
bjornfor
bjornfor reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wouldn't it be a good idea to wait until this has landed on master first, so that any fallout is known before backporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

@vcunat vcunat Awaiting requested review from vcunat

@gebner gebner Awaiting requested review from gebner

@prusnak prusnak Awaiting requested review from prusnak

@amiloradovsky amiloradovsky Awaiting requested review from amiloradovsky

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 5001+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Scrumplex @bjornfor @FliegendeWurst @misuzu